Tung D. Le
Tung D. Le
This is one example of how to define a pass option: https://github.com/onnx/onnx-mlir/blob/main/src/Conversion/ONNXToKrnl/ConvertONNXToKrnl.cpp#L172
@manbearian I am fine that PR #1348 can be a short-term solution to make your usage of onnx-mIir work. For a long term solution, I would prefer to make the...
> please take a look at PR https://github.com/onnx/onnx-mlir/pull/1363 and let me know if this what you're thinking. @manbearian Thank you for quickly implementing the idea! Yes, it is what I...
@sstamenova DenseResourceElementsAttr seems to be the right choice to me too. We have used `OpaqueElementsAttr` to store encoded data (a raw array of chars) for NNPA, so to make sure...
> The first 4 bytes of the resource string is supposed to be the alignment. I tried to guess based on the tests what the intended alignment was, but since...
> @tungld I can update the tests, but I would like to know if the change works with the models that you mentioned. I think the way it's currently setup,...
> @tungld I looked at it again, and I think what will happen right now is that the explicitly specified alignment attribute on the constant will continue to work as...
@jenkins-droid test this please
@sstamenova unfortunately, I got wrong results on NNPA when using this patch. After digging into this patch a bit, I know the reason. Let me explain here. A key difference...
@etiotto I haven't yet had it. Will try to prepare one example.