onnx-mlir icon indicating copy to clipboard operation
onnx-mlir copied to clipboard

Published 20 hours ago • verified publisher icon onnx

Add the implementation of shape inference for max_roi_pool op

Open DavidChan0519 opened this issue 2 years ago • 6 comments

Signed-off-by: david.cheng [email protected]

DavidChan0519 avatar Mar 25 '22 02:03 DavidChan0519

Can one of the admins verify this patch?

jenkins-droid avatar Mar 25 '22 02:03 jenkins-droid

@jenkins-droid test this please

tungld avatar Mar 25 '22 02:03 tungld

We are not going to write shape inference code directly in ONNXOps.cpp but put them into folder src/Dialect/ONNX/ShapeInference. Also, we should use IndexExpr to compute shape inference because it will be used to allocate memory in the op lowering.

You can take RoiAlign as an example: https://github.com/onnx/onnx-mlir/blob/main/src/Dialect/ONNX/ShapeInference/RoiAlign.cpp

tungld avatar Mar 25 '22 04:03 tungld

We are not going to write shape inference code directly in ONNXOps.cpp but put them into folder src/Dialect/ONNX/ShapeInference. Also, we should use IndexExpr to compute shape inference because it will be used to allocate memory in the op lowering.

You can take RoiAlign as an example: https://github.com/onnx/onnx-mlir/blob/main/src/Dialect/ONNX/ShapeInference/RoiAlign.cpp

got it, I will modify it later

DavidChan0519 avatar Mar 25 '22 04:03 DavidChan0519

@DavidChan0519 there is some conflicts, can you do the manual merge? It looks like its good to go then

AlexandreEichenberger avatar May 31 '22 13:05 AlexandreEichenberger

@DavidChan0519 are you able and willing to manually merge this PR?

AlexandreEichenberger avatar Aug 07 '22 21:08 AlexandreEichenberger

@DavidChan0519 are you able and willing to manually merge this PR?

I will resolve the conflict and then submit it again.

DavidChan0519 avatar Aug 26 '22 08:08 DavidChan0519

Can one of the admins verify this patch?

jenkins-droid avatar Aug 26 '22 08:08 jenkins-droid

@jenkins-droid test this please

tungld avatar Aug 26 '22 09:08 tungld

Can one of the admins verify this patch?

jenkins-droid avatar Aug 26 '22 16:08 jenkins-droid

@DavidChan0519 could you please sign DCO so that we can merge this? Thanks!

tungld avatar Aug 31 '22 02:08 tungld

Can one of the admins verify this patch?

jenkins-droid avatar Aug 31 '22 02:08 jenkins-droid

@jenkins-droid test this please

tungld avatar Aug 31 '22 03:08 tungld

@DavidChan0519 this is the suggested instruction to fix DCO: https://github.com/onnx/onnx-mlir/pull/1267/checks?check_run_id=8105622451

tungld avatar Aug 31 '22 03:08 tungld

@DavidChan0519 this is the suggested instruction to fix DCO: #1267 (checks)

thanks，let me see it

DavidChan0519 avatar Aug 31 '22 06:08 DavidChan0519

Can one of the admins verify this patch?

jenkins-droid avatar Aug 31 '22 06:08 jenkins-droid

Jenkins Linux ppc64le Build #6353 [push] Add the implementation o... failed after 2.2 sec

jenkins-droid avatar Aug 31 '22 06:08 jenkins-droid

Can one of the admins verify this patch?

jenkins-droid avatar Aug 31 '22 06:08 jenkins-droid

Jenkins Linux s390x Build #7304 [push] Add the implementation o... failed after 2.2 sec

jenkins-droid avatar Aug 31 '22 06:08 jenkins-droid

Jenkins Linux amd64 Build #7288 [push] Add the implementation o... failed after 1.3 sec

jenkins-droid avatar Aug 31 '22 06:08 jenkins-droid