Barry Pollard
Barry Pollard
Nice details (though a replication would of course be better). Should be fixed in #440
Alternatively we could introduce a new `MetricWithAttributionType` with that definition (which would be consistent with `MetricType`) and leave `MetricWithAttribution` alone for now. Then make the `MetricWithAttribution` change in v4, to...
Anyone any more thoughts on this? @brendankenny @mcanu @philipwalton
CLosing in favour of #471
The first waits for readystate of `interactive`, but that doesn't mean the web-vitals.js script has loaded, nor executed. Which is necessary to ensure the document visibility change is monitored. Going...
Actually this could also be the issue with test case 2 and 3, since the default Event Timing threshold is 104ms and the tests are often for 100ms. So if...
So I see there's logic to add `__testImport` calls to `__readyPromises` but I don't think that's enough for two reasons: 1. The script may not have executed before calling `interactive`...
Closing as most issues under our control have been fixed.
Can definitely do the analysis but less keen on authoring this year. @pmeenan or @LPardue any interest in authoring this year? Or anyone else you know that might be interested?
@mgifford maybe we could collect all a11y suggestions into a single issue? That way we can easily find them all in one place and also keep the issues list a...