Barry Pollard
Barry Pollard
OK that worked. So I guess it's just a slow client-side redirect and Wappalyzer might be running too early.
Actually I've one more question on this. Currently the Shopify Buy Button is in category 100: ``` "name": "Shopify apps", "description": "Extend the functionality of Shopify stores", ``` My understanding...
Ah OK so it is more like a fancy embedded link from a store to another site, rather than a completely separate thing (whichb is Shop Pay by the sounds...
Yes you're correct as to why this happens. By not registering the `visibilitychange` event listener until after FCP, your code's event listener get in first, and so they run first....
Sounds good. There’s also a few cases (including that one!) that register the `visibilitychange` event listener without the `document.` prefix so should fix that at the same time.
Alternatively couldn't we just escape it when you run your querySelector? `document.querySelector(CSS.escape('button.md:hidden-yes'))` Just worried about that escaped sequence causing more confusion...
Since we're making a breaking change to the selectors in v5 anyway thanks to #518 maybe we should consider this again @philipwalton . WDYT?
OK let's close then.
This was fixed in #527
This seems way too heavy. We’re prerendering all 10 reports (which is the absolute max allowed btw!) even though the user is at best case going to get value out...