Barry Pollard

Results 688 comments of Barry Pollard

Update on this issue: > Element node is not reported for some FID/INP entries. [Chrome bug - 1428899](https://bugs.chromium.org/p/chromium/issues/detail?id=1428899) > Element node is not reported when element is disconnected from the...

As noted in https://github.com/GoogleChrome/web-vitals/issues/335#issuecomment-1625311650 there were two main outstanding issues that we were aware of - both issues in Chromium rather than anything this library can necessarily resolve. 1) Certain...

MAybe should leave the current category as is, and add a new "Shopify CMS" category then with reduced checks?

That does indeed make it better, but still a drop of 1-2k, but maybe that's how many non-Shopify CMS Shop Pay sites there are? type|client|origins --|--|---: both|desktop|533,808 both|mobile|618,420 sdks only|desktop|532,141...

https://docs.google.com/spreadsheets/d/1FQpWNtazy4leIhjdRx5jHaQX1I2r-p5aaXO0etBC9VI/edit?gid=334521558#gid=334521558

@yoavweiss @krzksz do have you any opinions here? @rockeynebhwani is concerned we're over detecting Shopify sites as we currently consider any site loading any asset from `sdks.shopifycdn.com` or `cdn.shopify.com` as...

> I happy to do all of the above, or just the extra portion, just let me know what you prefer. Let's have @rockeynebhwani make the additional two changes I...

Go any example sites of each that you can add to the first comment to test the detection?

I don't understand why https://www.napoleon.com/ failed to match the `Shopify Buy Button` detection. Anyone spot anything I can't? Other than that, this looks good.

> * https://www.napoleon.com/en/ca/corporate/welcome I also tried changing it to the final URL I see: https://www.napoleon.com/en/ca/corporate/welcome Maybe the detection happens before the redirect happens? Rerunning now to check... But yes, it...