Tim Sweña (Swast)
Tim Sweña (Swast)
@ace-n PTAL
> Exact count distinct is already expensive, but just curious if the overhead of string encoding would show up here for anything but smaller-scale queries. We make the same workaround...
Merging. `doctest` and Samples test failures appear to be unrelated.
Thanks for the feature request! This is currently possible using the [`bigframes.options.bigquery.credentials` property](https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes._config.bigquery_options.BigQueryOptions#bigframes__config_bigquery_options_BigQueryOptions_credentials): ```python from google.oauth2 import service_account import bigframes.pandas as bpd credentials = service_account.Credentials.from_service_account_file(' path/to/key.json' ) bpd.options.bigquery.project = "YOUR-PROJECT-ID"...
https://github.com/geopandas/geopandas/issues/1947 is kinda the opposite of what I'm doing here. Those are about copying the implementation of the register accessor API from pandas to geopandas so folks can register geopandas-specific...
> Do your users expect to be able to use geodataframe exclusive methods like sjoin, clip, etc? At the moment, in BigQuery DataFrames we're actually just exposing the Series accessors....
Regarding the failing test, it's passing for me: ``` pytest geopandas/tests/test_geodataframe.py::TestDataFrame::test_set_geometry_col =============================== test session starts ================================ platform darwin -- Python 3.11.2, pytest-8.1.1, pluggy-1.4.0 rootdir: /Users/swast/src/github.com/geopandas/geopandas configfile: pyproject.toml collected 1 item...
> Is Google Cloud willing to support the maintenance in a long term, if you want to use this feature? Unlikely. I made this change on my personal time over...
It seems to me that the `GeoSeries` change is less controversial. Would you like me to remove the `GeoDataFrame` accessor since it's more likely to cause trouble?
> > Would you like me to remove the GeoDataFrame accessor since it's more likely to cause trouble? > > I think in terms of trying to progress this in...