Tim Sweña (Swast)
Tim Sweña (Swast)
`test_timestamp_extract` looks like a pretty simple data type difference: expects `int32`, gets `int64`. Should probably expect `int64`, since there isn't a 32-bit integer type for BigQuery. The others look a...
Re: `FAILED ibis/tests/all/test_array.py::test_array_concat[BigQuery] - ValueError...` It looks like arrays are coming back as numpy arrays in the BigQuery backend. Not sure if this is intended or not. If it is...
Not a bad idea to make it easier to catch new failures. Some of these are true failures (perhaps caused by changes in the Impala backend, since the BQ backend...
I see some in `test_aggregation.py` have multiple markings: ```python @pytest.mark.xfail_unsupported # Issues ibis-project/ibis#2133 ibis-project/ibis#2132# ibis-project/ibis#2133 @pytest.mark.xfail_backends([Clickhouse, MySQL, Postgres]) @pytest.mark.skip_backends([SQLite], reason='Issue ibis-project/ibis#2128') def test_topk_filter_op(backend, alltypes, df, result_fn, expected_fn): ``` Do you...
The `covar` tests appear to be fixed after ibis-project/ibis#2367, but several new test failures popped up. ``` FAILED ibis/tests/all/test_aggregation.py::test_aggregate[BigQuery-mean] - As... FAILED ibis/tests/all/test_aggregation.py::test_aggregate[BigQuery-complex_sum] FAILED ibis/tests/all/test_aggregation.py::test_aggregate_grouped[BigQuery-complex_sum] FAILED ibis/tests/all/test_aggregation.py::test_reduction_ops[BigQuery-no_cond-count] FAILED ibis/tests/all/test_aggregation.py::test_reduction_ops[BigQuery-no_cond-sum] FAILED...
Found in ibis-project/ibis#2353 As with ibis-project/ibis#2370, I think this failure is probably due to using Arrow as an intermediate format in the google-cloud-bigquery library.
I think this was actually a regression in Ibis 1.4.0, as I get this same `NotImplementedError: 'visit_Constant' nodes not yet implemented` when I run the code from the [ibis bigquery...
As we are splitting BigQuery to it's own repository (https://github.com/ibis-project/ibis/issues/2665), I'll track the fix for this here: https://github.com/ibis-project/ibis-bigquery/issues/6
Found in ibis-project/ibis#2353
You're right. Not sure why we didn't add `black` to the GitHub Actions. Other than the conventional commits convention, I agree that we should align with the main `ibis` project....