Tim Sweña (Swast)
Tim Sweña (Swast)
@martinfleis @m-richards Where would be an appropriate place to continue this discussion? P.S. I've removed the more controversial parts (DataFrame accessor & using GeoSeries as the accessor class itself). I...
Looks like the new buffer test is failing with Python 3.9 and pandas 1.5 and "latest". I'll look further into it.
Now test_series_geo_buffer is only failing on Python 3.9 and pandas 1.5. Not sure if it's worth trying to fix that now, or waiting until geopandas drops pandas 1.5, or abandoning...
I'm having trouble reproducing the `ubuntu-latest, ci/envs/310-pd20-defaults.yaml` failure. `python -m pytest geopandas/tests/test_pandas_accessor.py` passes just fine on my mac ``` $ python --version Python 3.10.0 $ python -m pip freeze certifi==2024.8.30...
https://github.com/geopandas/geopandas/pull/3272/commits/e29e3fc4b1682d0bb861f32587823403f896241b fixes. Seems `minimum_bounding_radius()` maybe isn't 100% perfect with regards to my assumption about all rows being `> 0.2`. I replaced the `all` call with a dumber loop to make...
@m-richards Is there anything blocking this from being merged? Happy to help if so.
`Kokoro notebook` failure: `FAILED notebooks/dataframes/pypi.ipynb:: - RelationError: Table schemas must be equal for set operations`. I believe this is internal issue 361145903.
Are there other properties besides `dryRun` that should be sent?
I think a general “update” call would be a good way to implement this. We’d probably want some checks for duplicate values. I think the current implementation checks that query...
I believe I might have fixed this issue in https://github.com/pydata/pandas-gbq/pull/152. I'll add a test to try out a `"dryRun": True` query before closing this issue.