Tim Sweña (Swast)

Results 302 comments of Tim Sweña (Swast)

Thanks for the request! This sounds reasonable to me. I believe the `connect` method is pretty flexible with regards to the arguments it accepts. I'd be open to a PR...

Failing tests: ``` index : int64 Unname...4 date_string_col : string string_col : string timestamp_col : timestamp year : int64 month : int64 df = index Unnamed_0 id bool_col tinyint_col ......

``` (ibis-bigquery-dev) ➜ ibis-bigquery git:(compat_ibis2) PYTEST_BACKENDS="bigquery" python -m pytest --pyargs ibis.backends.tests.test_api::'test_database_consistency[bigquery]' --disable-pytest-warnings ================================================================== test session starts =================================================================== platform darwin -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 rootdir: /Users/swast/src/github.com/ibis-project/ibis-bigquery plugins: cov-2.12.1, mock-3.6.1...

``` (ibis-bigquery-dev) ➜ ibis-bigquery git:(compat_ibis2) PYTEST_BACKENDS="bigquery" python -m pytest --pyargs ibis.backends.tests.test_generic::test_select_filter_mutate --disable-pytest-warnings ================================================================== test session starts =================================================================== platform darwin -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 rootdir: /Users/swast/src/github.com/ibis-project/ibis-bigquery plugins: cov-2.12.1, mock-3.6.1...

One thing that's relevant to issue is how to expose these UDFs once they are available. I see that the postgres backend has support for this (recently touched in https://github.com/ibis-project/ibis/pull/3932)....

These seem reasonable to add. It would be possible to add these in this dialect and monkeypatch in as is done here: https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/third_party/ibis/ibis_addon/operations.py My preference is to add any new...

@renato2099 Yeah, a bunch of missing docstrings. I'm undecided if it's worth adding all of these, as I expect most people will be referring to the actual ibis docs for...

Might want to use https://github.com/google-github-actions/release-please-action

I've setup the conventional commits linter and release-please bots from https://github.com/googleapis/repo-automation-bots This should at least automate maintenance of `version.py` and the changelog. The actual push to PyPI (and then conda-forge)...

Not sure why release-please didn't open a PR. Using the NPM package locally worked. Release at https://pypi.org/project/ibis-bigquery/0.1.0/