Timo Rößner comments

Results 83 comments of


                                            Timo Rößner

Somehow let Reek examine ruby files that don't have the .rb extension

``` Bash file Rakefile Rakefile: ASCII text ``` No way of doing that without shebang. I see 3 possibilities here: 1.) We expect ruby files to have a shebang and...

A strategy for making our --todo feature more useful

Glad you like it, I'll work on this the next couple of weeks. [1] is trivial and [3] is easy given [2]. So [2] is gonna be the big one...

A strategy for making our --todo feature more useful

I'll tackle [2] in the next couple of days / weeks ;)

Rule Request: UnnecessaryShellCommand

I like it! Are you up for a pull request? If yes, we'd guide you through it ;) If not that's fine as well, it just might take us a...

Clean up config handling

:+1:

Initialising instance variables to nil

How about suggesting to not make it an instance variable at all?

Initialising instance variables to nil

But thats what we have a /docs page for, dont we? We can then discuss examples there. We do the same thing for other more complex smells like FeatureEnvy.

TooManyMethods only checks instance methods

Thanks for the pull request! One thing though, could you please add a spec that tests the new behaviour explicitly rather than implicitly?

Thread safety

I agree. Let's fix this. But this kind of implies to go through our complete codebase and check all-the-things, right?.:)

Make releases less noisy

That is a very good idea, thank you for that :) We might come back to this in the future.