Timo Rößner

Added this smell detector to #556 and referenced this issue there -> closing this one.

Seems like we had a misunderstanding, re-opening, see my last comment on #633

I like it a lot how we're separating this into meaningful units. So so far we have: - respond_to? -> ManualDispatch, wip right now. - `is_a?` and `kind_of?` calls ->...

Quickly summarizing the status of this issue: - respond_to? -> ManualDispatch: done - nil? -> NilCheck: done - is_a? and kind_of? calls -> SimulatedPolymorphism, not there yet. So only the...

>> It shouldn't do this if all of the conditionals are local variables. Fair point! That should be fairly easy to fix, thanks for the bug report.

I would be perfectly fine with making it less strict. Maybe everything less than 3 statements is fine?

Agreed!

I think we now have a much more cleaner and consistent error handling as at the time of writing this ticket. Wouldn't it be enough to catch all StandardErrors in...

> > It would be nice of reek to do the same - report if some inline suppressions are no longer needed and could be removed. Yes, yes and double...

Sounds like a plan @mvz !