reek icon indicating copy to clipboard operation
reek copied to clipboard

Published 20 hours ago • verified publisher icon troessner

TooManyMethods only checks instance methods

Open whiteleaf7 opened this issue 2 years ago • 2 comments

https://github.com/troessner/reek/blob/master/lib/reek/smell_detectors/too_many_methods.rb#L39

TODO: Only checks instance methods!

I resolved the todo above.

whiteleaf7 avatar Jun 15 '22 02:06 whiteleaf7

Thanks for the pull request! One thing though, could you please add a spec that tests the new behaviour explicitly rather than implicitly?

troessner avatar Jun 15 '22 16:06 troessner

@troessner 0bd6fca I have modified the test, could you please check the test?

whiteleaf7 avatar Jun 16 '22 02:06 whiteleaf7

@whiteleaf7 any chance you'll pick this up again?

troessner avatar Jan 17 '23 17:01 troessner

Closing this one since it has become stale, feel free to re-open @whiteleaf7

troessner avatar Oct 10 '23 12:10 troessner