Tim Flynn
Tim Flynn
I've pushed up what that looks like. So now for an IPC like: ```c++ run_javascript(u64 page_id, String js_source) =| ``` We will generate: ```c++ void async_run_javascript(u64 page_id, StringView js_source) {...
From what I can tell, the first instance of this crash on CI was commit 9b26f7eb0faaca63ee9109c6eda44c82a6acfeaf
Ah! Yeah If I enable that, then I get the same behavior as Jelle. @gmta do you have that enabled? (I had to disable it again to write this comment,...
I have a WIP stash where I've started using gmp for BigInt, and mpfr for BigFraction, so I'm seeing how those pan out. > Could you please point me to...
I just added a FIXME comment for now since it looks like getting the CSS rule/declaration will require more scaffolding
Compatibility with node is a non-goal, so we don't have plans to change the way we print quotes. We do have a flag already to disable ANSI colors, called `--disable-ansi-colors`....
It's not that we're calling `to_string()`, it's that we're adding the quotes on purpose here: https://github.com/LadybirdBrowser/ladybird/blob/780de1395bcb5681f392f5b27a840800966a8c14/Libraries/LibJS/Print.cpp#L1039-L1040 https://github.com/LadybirdBrowser/ladybird/blob/780de1395bcb5681f392f5b27a840800966a8c14/Libraries/LibJS/Print.cpp#L1050-L1051 Personally, I like having the quotes in `js`.
> I did notice that Safari and Firefox both behave like Node here Oh, I also wanted to note that the devtools and REPLs are separate - our devtools will...
UCD/CLDR updates breaking tests is pretty normal, and we typically just update our tests to match the new expectations (assuming they don't uncover a bug on our end). But we...