Trevor Gerhardt
Trevor Gerhardt
This code is mostly a duplicate of the code in the `BrokerController` (in fact it was originally copied from there). Should we abstract this out as a helper method in...
These are the stock templates provided by Github, they are a great start but we may want to customize them to fit our needs.
A free service provided by Github, this action "runs GitHub's industry-leading semantic code analysis engine, CodeQL, against a repository's source code to find security vulnerabilities. It then automatically uploads the...
When uploading [this](https://opendata.arcgis.com/datasets/1559e31273654eb9858397861f1fdefa_10.geojson) GeoJSON file to use as a Data Source the following issue is displayed: It appears all of the geometry in this file are `Polygon` or `MultiPolygon`. I...
An incoming single point analysis request contains the `bundleId` and set's it on the `AnalysisWorkerTask` as the `graphId` here: https://github.com/conveyal/r5/blob/f71de5235a8ec773e91f3ddbec134bb5f5fecdb2/src/main/java/com/conveyal/analysis/models/AnalysisRequest.java#L202 Later, the worker task is used in the `NetworkPreloader` and...
The naming of the `RegionAnalysis#request` parameter can lead to some pretty serious confusion. It's set to the `RegionalTask` but the `RegionalTask` is created from an incoming `AnalysisRequest`, which is different.
We currently store the _ids used, which is convenient and useful for tracking down the exact point set used for the regional analysis, but without the names a few issues...
We should consider explicitly validating all incoming data in HTTP requests in a specific step. We assume a lot of correctness because the data is coming from an interface that...
We currently need to pass a `String bucket` almost everywhere that we use and instance of `FileStorage`. We should consider creating a simple `Bucket` abstraction that wraps the `FileStorage` with...
While experimenting with returned `pathSummaries` I was looking at the appended JSON block (https://github.com/conveyal/r5/blob/dev/src/main/java/com/conveyal/r5/analyst/cluster/AnalysisWorker.java#L513) and became curious as to the size / speed difference of returning the entire result set...