David Feuer
David Feuer
I don't understand what you mean about a middle bit. A bit more explanation of where I was heading: For each suitable left child, we choose one or more suitable...
Ah, the pattern is obvious now that I see it. Silly me! We *always* go *up* by one in length after a subset that does not include the maximum value....
@jwaldmann This is absolutely just a puzzle. IIRC, I added `powerSet` to `Data.Set` because @ekmett thought it should be there, and offered the simple implementation we currently use. Something `Set...
@meooow25 Your implementation looks interesting, but I can't make head or tail of how it works. Could you explain? How does it achieve lexicographical order? ~~I also noticed a type...
Wait, now I'm confused... How does that typecheck?
@meooow25 Your implementation doesn't pass the test suite, unfortunately. I'm still very confused about how it passes the type checker.
To clarify, it doesn't pass the test suite once the test has been changed as in #892. That's (at least partly) because the subsets you produce are totally unbalanced—just lists.
Yes, the whole thing? I don't understand the shape of it. Could you maybe open a PR with lots of comments? I'm a comment maximalist.
@meooow25 FWIW, I would prefer to get a PR, even before perf testing. That'll sic CI on it, and make it easier for me (or others) to play with the...
@meooow25 That's disappointing; I'd have expected an automatic performance boost from just reducing the result size. Two things to consider: 1. Make `sortedMasks` a right fold instead of a left...