David Feuer
David Feuer
Both `fromSet` and `fromSetA` seem to be missing validity (i.e., data structure invariant) tests. I don't understand your (partial?) collection of `Arbitrary` instances, or why that's in this PR.
Understood. The function you're looking for is called `valid`. For largely hysterical raisins, it's actually exposed from `Data.Set`. (In modern Haskell library design, there'd probably be a separate `Unsafe` module...
You seem to have done some substantial reworking of `Arbitrary` instances here, none of which are related to the purpose of the PR. Please don't do that. You can propose...
The purpose of `IsInt` is to support potential future Haskell compilers that don't support GHC-style type equality constraints. I believe @ekmett is among those who thinks those are a plausible...
The last I heard, MHS wasn't ready for QuickCheck. But maybe @augustss can give us an update.
I definitely don't think that change belongs in this pull request; it's a much better fit for the other one.
@meooow25 , the constraints are used in `base`, so there shouldn't be any issue using them in other boot libraries.
FWIW, I always run `killall -STOP firefox` before running benchmarks and `killall -CONT firefox` after, but I don't claim to be good at achieving a "quiet" system.
> We have `Data.List.unsnoc :: [a] -> Maybe ([a], a)`, so I think it would be useful to have your `initLast` as `Data.List.NonEmpty.unsnoc :: NonEmpty a -> ([a], a)`. >...
Why doesn't the new package support older GHC versions? The CPP seems a bit blecherous.