David Feuer
David Feuer
If our invariants are violated by someone external using internal functions incorrectly, then crashing with an error is the *best* outcome you can hope for. If you can reproduce the...
The internals are not *in* the public API. The invariant is documented in the source code. If you'd like to add or improve documentation, such a contribution will always be...
@simonmichael That's because the internals are being used in some *other* Cardano package, if I understand the original ticket. Doesn't `cardano-node` import other Cardano things?
It wouldn't be bad to add Haddocks for `balanceL` and `balanceR`. They're documented in source, but it's not the most accessible documentation.
No, we don't want to use `vector`. We could pull in some bits of `primitive` if we need to, but I'd rather get those bits shifted into `base`.
Do you want to beat this into mergeable shape by tomorrow so it can go in the next release? I would love to reduce the memory requirements ASAP.
@meooow25 , you might want to experiment with this.
Yeah, something like that for the listy ones (if it's not too slow). I'm a bit more skeptical about `dfs` itself (which needs lazy `ST`); we'll need benchmarks with different...
Is there some actual reason for `topSort` to be defined in terms of a postorder and not a preorder? Wouldn't it be more efficient to just define it as a...
Oh, I see.... No.