David Feuer

Results 993 comments of David Feuer

Can we make the Map.Merge API more expressive?

Interesting. My immediate intuition is that there might be a nice way to do this with a `Biapplicative` analogue of the merge API. I'll try to think later about whether...

first benchmark is expensive

My guess is that sharing is the problem. Do things improve if you write it like this? ```haskell main = defaultMain [ bench "1" $ nf length [1 .. 10^7...

Use a relative src dir path in containers-tests instead of a symlink.

Let me know when you get it working and I'll merge.

Use a relative src dir path in containers-tests instead of a symlink.

Any further ideas?

intset-benchmarks no longer build on windows.

Hmmm... Yeah, I think we use symbolic links to share files between `containers` and `containers-tests`. Do you know a better way?

intset-benchmarks no longer build on windows.

Can you try it and open a PR?

Data.Set.fromDistinctAscListN

Also descending versions?

Data.Set.fromDistinctAscListN

Your implementations all look weird to me. This is a deserialization problem. ```haskell fromDistinctAscendingListN :: Int -> [a] -> (Set a, [a]) fromDistinctAscendingListN n xs | s :!* remains [a]...

Data.Set.fromDistinctAscListN

Mine looks a lot like a direct version of your continuation-passing ones. I'd expect it to be easier on the optimizer.

Data.Set.fromDistinctAscListN

I agree none of this makes sense. There's no reasonable world in which adding the overhead of `STRef` and such should improve matters. Is GHC doing something very silly? Was...