Silvio Traversaro

Results 2512 comments of Silvio Traversaro

Hello @sashacmc @DenisBiryukov91, do you have any further feedback on the PR? Thanks!

> I don't mind to the proposed logic: if CARGO_BUILD_TARGET is set then use it, but if ZENOHC_CUSTOM_TARGET is set it overrides the CARGO_BUILD_TARGET. > > There is only one...

> PR missing one of the required labels: **{'internal', 'documentation', 'new feature', 'breaking-change', 'enhancement', 'dependencies', 'bug'}** I do not think I have the permissions for adding any labels.

See also https://github.com/conda-forge/opencv-feedstock/issues/293 .

> Looking through [conda-forge/opencv-feedstock#293](https://github.com/conda-forge/opencv-feedstock/issues/293), given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with...

> Looking through [conda-forge/opencv-feedstock#293](https://github.com/conda-forge/opencv-feedstock/issues/293), given it's age and the general conclusion that the maintainers didn't want to add this in that feedstock, is there an issue with moving ahead with...

xref: https://github.com/conda-forge/ale-py-feedstock/issues/19 and https://github.com/conda-forge/ale-py-feedstock/pull/20 . The main blocking issue on the conda side is that the legal situation w.r.t. to redistribution of the rom is not clear.

As without proper licensing we can't distribute ROMs on conda-forge, we mitigated the issue in https://github.com/conda-forge/ale-py-feedstock/pull/26 by documenting how external ROMs can be loaded. @TheophileChampion is that sufficient to solve...

> Could we add a custom error in conda to users to explain the error? Then we should be able to close this issue Good point! I opened https://github.com/conda-forge/ale-py-feedstock/issues/29 to...