valkyrie icon indicating copy to clipboard operation
valkyrie copied to clipboard
verified publisher icon samvera

add StorageAdapter#id_for

Open dunn opened this issue 3 years ago • 3 comments

Closes GH-887.

dunn avatar Oct 20 '22 18:10 dunn

@tpendragon is https://github.com/samvera/valkyrie/wiki/Storage-&-Files the only place where we specify the methods that adapters are expected to provide?

dunn avatar Oct 20 '22 18:10 dunn

Yeah I think so. It might be nice to use id_for in #upload too.

tpendragon avatar Oct 20 '22 18:10 tpendragon

Now it's failing for test coverage reasons, but I'm confused and also not sure how to write specs for id_for because there aren't specs for upload.

dunn avatar Oct 28 '22 21:10 dunn