Tony Najjar

Results 122 comments of Tony Najjar

Which formatter/linter is used here?

> Agreed- though something not working I could argue should be removed because its deceptive. small feedback: It did turn out to be deceptive for me, spent some time debugging...

Also being worked on here: https://github.com/PickNikRobotics/rviz_visual_tools/issues/181

I found that Foxglove supports visualizing the Frustum from the camera_info topic ![image](https://user-images.githubusercontent.com/14879660/180273084-de13b42c-1949-403b-9e83-b91b42dc5bce.png) The problem is still that STVL's frustum are not created based on the camera_info topic, but based...

> Feature request: STVL creates the Frustums from the camera_info if it exists, fallbacks to parameters. Let me know if you want me to create a separate feature request for...

We were almost going to give a shot implementing it but realized that gazebo/OGRE also doesn't support other frustum shapes (looks like they are really rare). We instead went with...

What's the main reason to implement this? I'd imagine to see the debug logs? Running it in debug mode is unreadable because of all the "sub-loggers" like rcl

Alright, to have useful readable debug logs only from Nav2, I'd recommend looking into changing the severity from **individual** loggers. It's available since galactic https://docs.ros.org/en/galactic/Tutorials/Demos/Logging-and-logger-configuration.html

> @tonynajjar so what's your plan here? Remake something using that as a reference or wait for it to be ported and we can go through some design reviews to...

@bmagyar are you getting the notifications on this PR? Could you advise on how to proceed? https://github.com/ros-controls/ros2_controllers/pull/345