navigation2 icon indicating copy to clipboard operation
navigation2 copied to clipboard

Published 20 hours ago • verified publisher icon ros-navigation

Log level

Open jwallace42 opened this issue 2 years ago • 1 comments

Basic Info

Info Please fill out this column
Ticket(s) this addresses None
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo

Description of contribution in a few bullet points

Adds ability to set log level for nodes that are launched.

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

jwallace42 avatar Aug 12 '22 14:08 jwallace42

@jwallace42, please properly fill in PR template in the future. @stevemacenski, use this instead.

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

mergify[bot] avatar Aug 12 '22 14:08 mergify[bot]

So,

you can't set the log level of individual components :( only the container that holds the components. I guess this makes sense but it would be nice to be able to set the log levels of each component.

jwallace42 avatar Aug 21 '22 22:08 jwallace42

@jwallace42 rerunning CI, an unusual failure occurred. I don't think its your fault, but want to just check again.

SteveMacenski avatar Aug 22 '22 16:08 SteveMacenski

Can you rebase on main? I'm seeing that same error again which I'm not seeing on other PRs in some utils action server unit tests.

SteveMacenski avatar Aug 22 '22 18:08 SteveMacenski

The PR got a little messed up, its showing a bunch of other commits.

SteveMacenski avatar Aug 22 '22 21:08 SteveMacenski

So,

I think this fixed it. I have to add a pr for some linting fixes that didn't get in on https://github.com/ros-planning/navigation2/pull/3114.

jwallace42 avatar Aug 23 '22 14:08 jwallace42

What's the main reason to implement this? I'd imagine to see the debug logs? Running it in debug mode is unreadable because of all the "sub-loggers" like rcl

tonynajjar avatar Aug 23 '22 19:08 tonynajjar

I didn’t ask, it seemed like a reasonable request to expose that as a CLI option

SteveMacenski avatar Aug 23 '22 19:08 SteveMacenski

Alright, to have useful readable debug logs only from Nav2, I'd recommend looking into changing the severity from individual loggers. It's available since galactic

https://docs.ros.org/en/galactic/Tutorials/Demos/Logging-and-logger-configuration.html

tonynajjar avatar Aug 23 '22 19:08 tonynajjar