tommasini

Results 83 comments of tommasini

Solved the E2E issue by discovering that it was needed to handle the state property `contractBalances` of TokenBalancesController, as the balance is no longer is a BN but yes a...

Created also a regression E2E build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97ab095e-1d38-4e76-9bf9-7da5cb7635bf

Heyy, this seems to have more changes than it should have, I don't know if it's a github glitch, could we merge main and solve conflicts? If it doens't solve...

Closing this PR since it's outdated

> [The password strength text is too long](https://www.screencast.com/t/l6YLDdv6p5) Fixed: https://recordit.co/swMb44v0U2 > When I go through the onramps flow the translated “cancel” button is misaligned > The Add funds button is...

Hey @php4fan , thank you for report, sorry for taking so long to answer. Answering the issue of opening https://opentarget.org/test/stupid/mm/trans/ and pressing the send transaction, I'm not being able to...

Moving this to closed since It was merged a [PR](https://github.com/MetaMask/metamask-mobile/pull/9721) to improve performance Not sure if we should close it or remain it open @gauthierpetetin

Ah okok! I thought that it was something that we wanted to do to to every controller that it was still extending v1, sorry my mistake!

Added! By mistake I left my description under the comments of the PR template

@Daniel-Cross Amazing work, before merge can you add a recording of cancelling the qr code not crashing the app?