tommasini
tommasini
Hey @nikoferro, awesome work! I see dedupe issues, can you solve those, please?
@SocketSecurity ignore npm/@metamask/[email protected] It seems that the issue presented on this version, were already existing (detected when core repo converted to mono repo) and with an ethereumjs lib that we...
This branch is awaiting changes to the transaction controller * https://github.com/MetaMask/metamask-mobile/pull/8774 * https://github.com/MetaMask/metamask-mobile/pull/8784 Once this work is updated on the respective core branch: `patch/mobile-transaction-controller-7-1-0` this work will be ready for...
@SocketSecurity ignore-all It seems that no packages were added/removed/updated during this updated to transaction controller
@seaona I'm tagging assets, team I believe it's assets team that owns this work
> Why are we attempting to get the balance before initialization? Perhaps we should show a loading indicator until after initialization has completed Definitely we should have a loading indicator!...
> Good catch! This bug seems to be upstream as well. Could you fix this in core? Yes I can! I have some core PRs that I've being always postponed...
Core PR: https://github.com/MetaMask/core/pull/3933
Forgot to paste here, issue created: https://github.com/MetaMask/mobile-planning/issues/1566
E2E is failling and it seems to be because of `hexToBN` function that was changed on the bump of ethereumjs-util on this [PR](https://github.com/MetaMask/core/pull/3943) It seems that it was changing the...