feat: Update signature controller v13
Description
- Update Signature Controller to v^13
- Changelog here
This controller needs this versions to be updated first:
- "@metamask/approval-controller": "^5.1.2",
- "@metamask/keyring-controller": "^13.0.0",
- "@metamask/logging-controller": "^2.0.2"
Issue: https://github.com/MetaMask/mobile-planning/issues/1699
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@metamask/[email protected] | Transitive: environment, filesystem, network, shell | +36 |
9.02 MB | metamaskbot |
| npm/@metamask/[email protected] | Transitive: filesystem | +29 |
3.89 MB | metamaskbot |
| npm/@metamask/[email protected] | Transitive: filesystem, network | +7 |
1.95 MB | metamaskbot |
| npm/@metamask/[email protected] | Transitive: filesystem | +6 |
1.87 MB | metamaskbot |
| npm/@metamask/[email protected] | Transitive: filesystem | +12 |
3.02 MB | metamaskbot |
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]
Heyy, this seems to have more changes than it should have, I don't know if it's a github glitch, could we merge main and solve conflicts? If it doens't solve since the accounts related PR was merged we can create a new branch from main and cherry pick the needed changed from here
Heyy, this seems to have more changes than it should have, I don't know if it's a github glitch, could we merge main and solve conflicts? If it doens't solve since the accounts related PR was merged we can create a new branch from main and cherry pick the needed changed from here
I've closed this PR and made a new branch feat/update-signature-controllerv13. I noticed the extra changes 🤔