metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: Update signature controller v13

Open MarioAslau opened this issue 1 year ago • 3 comments

Description

  • Update Signature Controller to v^13
  • Changelog here

This controller needs this versions to be updated first:

  • "@metamask/approval-controller": "^5.1.2",
  • "@metamask/keyring-controller": "^13.0.0",
  • "@metamask/logging-controller": "^2.0.2"

Issue: https://github.com/MetaMask/mobile-planning/issues/1699

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

MarioAslau avatar May 02 '24 15:05 MarioAslau

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 02 '24 15:05 github-actions[bot]

Heyy, this seems to have more changes than it should have, I don't know if it's a github glitch, could we merge main and solve conflicts? If it doens't solve since the accounts related PR was merged we can create a new branch from main and cherry pick the needed changed from here

tommasini avatar May 06 '24 11:05 tommasini

Heyy, this seems to have more changes than it should have, I don't know if it's a github glitch, could we merge main and solve conflicts? If it doens't solve since the accounts related PR was merged we can create a new branch from main and cherry pick the needed changed from here

I've closed this PR and made a new branch feat/update-signature-controllerv13. I noticed the extra changes 🤔

MarioAslau avatar May 12 '24 19:05 MarioAslau