Matthew Riley MacPherson
Matthew Riley MacPherson
@eugene-manuilov The core notifications that will be registered aren't specific, since they're server notifications that are sent from the service. I've updated the IB, but we're essentially changing the creation...
The margins there aren't additional, they seem to be standard margins set in our styles, but the top margins do seem a bit much. I've adjusted them to look a...
ACs here are good, moving to IB 👍🏻
Looks solid, thanks for referencing the proof-of-concept PR, I forgot to include it in my original issue write-up, but added it now. Looks great, IB ✅
Marking this as approved/closed; [as mentioned above](https://github.com/google/site-kit-wp/issues/9338#issuecomment-2459542646), most of this will really be tested in #9339.
The "Enable One-tap" option was added later in the process so it wasn't originally in the Design Doc or Figma mocks; this also means it wasn't in the settings we...
IB ✅ I'll remove #9484 in that case 🙂
@benbowler Right, we should at least do a regex validation—in fact, I don't think a client ID would ever have spaces in it, so even just "no whitespace" is a...
(I realised today this is actually due for the next sprint, but leaving it assigned to me as I've nearly completed the issue already 😅)