site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

"Learn More" Link for Enhanced Conversion Tracking Toggle is Missing When Displayed Within Analytics Module Settings

Open 10upsimon opened this issue 1 year ago • 2 comments

Feature Description

The 'Learn More' link for enhanced conversion tracking toggle is missing under Analytics settings edit view as reported in this Release Issue comment.

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Learn More link should be added to the Enhanced Conversion Tracking toggle component when displayed within the Analytics module settings.
  • It should match in appearance, functionality and URL destination as it currently appears within the Ads module

Implementation Brief

  • [ ] Within the SettingsForm component at assets/js/modules/analytics-4/components/settings/SettingsForm.js
    • [ ] Define a variable that obtains the enhanced-conversion-tracking documentation URL obtained from the CORE_SITE store via getDocumentationLinkURL action, i.e select( CORE_SITE ).getDocumentationLinkURL( 'enhanced-conversion-tracking' )
    • [ ] Within the current opening <ConversionTrackingToggle> and </ConversionTrackingToggle> component body:
      • [ ] Replace the current __() textual output with a createInterpolateElement() function that includes the original text currently present, as well as the applicable "Learn more" link that links to the URL obtained via the useSelect() call further above, wrapped in an a <Link> component.
      • [ ] Reference to the existing Ads implementation at https://github.com/google/site-kit-wp/blob/3f5f52f261724a5e95d4f73eb9f8b2c8caa9fd1a/assets/js/modules/ads/components/settings/SettingsForm.js may be used for implementation correctness.

Test Coverage

  • Update VRT references as required following introduction of the Learn More link to the Enhanced Conversion Tracking toggle component to the Analytics settings view/edit view.

QA Brief

  • Setup Site Kit and Analytics module
  • Go to edit screen of Analytics module, and verify that learn more link is present and leads to the same location as the one on edit screen of Ads module (eg: https://sitekit.withgoogle.com/documentation/using-site-kit/enhanced-conversion-tracking/)

Note: The above URL is not live yet so the page will 404, but that is the expected URL and the help doc will be added later 😄

Changelog entry

  • Add a "Learn more" link for Enhanced Conversion Tracking.

10upsimon avatar Jul 01 '24 09:07 10upsimon

IB ✅

tofumatt avatar Jul 02 '24 22:07 tofumatt

QA Update ✅

  • Tested on dev environment.
  • Verified "Learn More" link for Enhanced conversion Tracking Toggle is added within Analytics module settings.
  • Verified that Analytics settings "Learn More" link matches in appearance, functionality and URL destination as it currently appears within the Ads module
  • Verified that "Learn More" link under Analytics leads to same position as Ads module ( https://sitekit.withgoogle.com/documentation/using-site-kit/enhanced-conversion-tracking/ )

image

image

https://github.com/google/site-kit-wp/assets/94359491/fd459854-c72d-4b5f-aa2f-5d663c38aadd

mohitwp avatar Jul 05 '24 12:07 mohitwp