Matthew Riley MacPherson

Whoops, this was meant to be a WIP/draft PR, but I forgot VSCode won't let me make those easily. At any rate, this removes callbacks and ES6-i-fies test and src...

Consolidate gettext strings.

1

## Summary Addresses issue: - #5659. ## Relevant technical choices After auditing the `.pot` file and the codebase it seems like there were very few issues with gettext consistencies. These...

Audit and consolidate gettext/translation strings for similar translations

3

We have a lot of small translation strings like “Get help”, “OK, got it!“, “Learn more” etc. throughout the codebase, but some of them have translation strings that are off-by-case,...

## Summary Addresses issue: - #3454. Note: this should probably be merge reviewed by @aaemnnosttv, @eugene-manuilov, @felixarntz, and/or @techanvil before merging, just to ensure accuracy and that we didn't miss...

## Feature Description We should replace the [`get_client()` function in `Module.php`](https://github.com/google/site-kit-wp/blob/26304ca85a87770a1e837f904cf983ea4d8040dd/includes/Core/Modules/Module.php#L554) with something like `get_oauth_client_for_current_user()`. See @felixarntz's comment here for context on this change: https://github.com/google/site-kit-wp/pull/5367#discussion_r898482631 --------------- _Do not alter or...

VRT tests cannot be run on ARM Macs/M1 Macs

11

## Bug Description Using an ARM/M1 Mac, running `npm run test:visualtest` will fail with an error because the Docker image for Backstop is not configured to run an ARM64 image....

Schedule a cron_refresh_profile_data function to run occasionally so we have up-to-date profile data

2

## Bug Description Currently we don't refresh a user's profile data in the background unless there was an error with a profile data request (see: https://github.com/google/site-kit-wp/pull/6002#discussion_r995217687). This has two issues:...

Use template strings for string interpolation

7

We should start using ES6's much nicer string interpolation instead of the string concatenation we currently do. Bonus points: we can use stuff like `oneLine` from the [common-tags](https://www.npmjs.com/package/common-tags) package like...

Missing moment locales for several of our own locales

5

Once #1514 is merged we're using [moment] for our dates but it's missing locales for the following locales we support: * [ ] ast - Asturian (missing) * [ ]...

Webpack plugin errors when using universal native node modules on macOS

2

### Pre-flight checklist - [X] I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses. - [X]...