Matthew Riley MacPherson comments

Results 353 comments of


                                            Matthew Riley MacPherson

Render Sign in with Google button on the wp-login page.

Let's actually update the colour values we use/store; since this isn't live yet it's fine to change them without migrations. Mapping them seems needlessly confusing since we haven't shipped anything...

Create Sign in With Google Settings module settings view screen

IB ✅

Create Sign in With Google Settings module settings view screen

Leaving this assigned to myself as I accidentally started this one, not realising it wasn't in the sprint 😅

Upgrade remaining GitHub Actions to Node 20

Moving directly to Approval since no QA is needed here.

Install/activate the WP Consent API plugin in the background.

The ACs say we should enable the WP Consent API plugin, but they don't say _when_/under what conditions. Enabling it automatically when it isn't enabled seems like a fine idea,...

Install/activate the WP Consent API plugin in the background.

Thanks, this makes sense 👍🏻 Moving to IB 👍🏻

Install/activate the WP Consent API plugin in the background.

IB ✅

No "Update" button for the "Most popular products...." key metric when googlesitekit_post_date dimension is not present

IB ✅

t.every is not a function

We should be able to check that `every` is available by using `report?.totals?.every?.( isEmpty )` instead of adding an additional check, which will be a bit harder to read here....

t.every is not a function

@zutigrm No worries, I probably would have done the same if I were writing the IB! 😅 IB ✅