Elias Rohrer

`WatchedOutput::block_hash` is not persistent across restarts

1

In [`WatchedOutput::block_hash`](https://docs.rs/lightning/latest/lightning/chain/struct.WatchedOutput.html#structfield.block_hash) we return the "[f]irst block where the transaction output may have been spent." However, we only set this `Some` when we initially process the parent transaction: https://github.com/lightningdevkit/rust-lightning/blob/1fdb052afc0a7200f31c806a2c3e0932f1914170/lightning/src/chain/chainmonitor.rs#L319 but...

Improve channel config parameter consistency

2

It's kind of confusing that we have different lower bounds for channel parameters, such as capacity. For example, while `ChannelHandshakeLimits::min_funding_satoshis` defaults to 0 and hence indicates that there is no...

Log peer's features if they require some unknown features we don't support

8

Previously, when a peer sends us features we don't understand we wouldn't log them, but just log `Peer requires features unknown to us`. Here, we fix this.

Limit `htlc_maximum_msat` to improve probing-privacy

2

We currently only limit our `max_htlc_value_in_flight_msat` which we're about to switch off based on announcement status in https://github.com/lightningdevkit/rust-lightning/issues/2851. As our `anti_probing_penalty_msat` penalizes channels that don't set `htlc_maximum_msat`, we might hence...

Make event handling fallible

1

Closes #2490. Previously, we would require our users to handle all events successfully inline or panic will trying to do so. If they would exit the `EventHandler` any other way...

Implement `Readable` for `Offer` and `Refund`

5

In order to make storing `Offer` and `Refund` objects easier, we here implement `Readable` for them (both already implement `Writeable`). As I'm not sure if this was omitted on purpose...

The intermediary fix in #2959 was added for v0.0.122 to quickly regain compatibility with CLN nodes. As CLN is about to fix this in a point release, we should revert...

Consider allowing for BOLT12 payments over unannounced channels

3

Currently, we only allow for BOLT12 payments if the introduction point is an announced announced node both payer and payee are connected to. It is my understanding that this is...

Allow to override config defaults for inbound channels on a per-channel basis

1

Currently our manual channel acceptance interface doesn't allow us to override any config defaults on a per channel basis, i.e., users can only accept or fail the inbound channel request,...

Update/remove remaining references to `KeysInterface`

2

See https://github.com/lightningdevkit/lightningdevkit.org/pull/226#issuecomment-1709447356