Elias Rohrer

We should early-abort sending in the regular BOLT12 `pay_for_offer` flow if we're certain we don't have sufficient liquidity (i.e. the offer amount surpasses the sum of our available `next_outbound_htlc_limit_msats`).

In our current implementation of `Persist::archive_persisted_channel` we first read the monitor, write it at the archive location and finally lazily remove the monitor to 'move' it to the archive. This...

Bump `esplora-client` to 0.10

2

.. the most-recent release. This is needed for compatibility with newer BDK versions (>= 1.0-beta.5).

BOLT12 sending doesn't allow to override `{Route,Payment}Parameters`

5

For BOLT11 we allow to set `RouteParameters` as an argument to `send_payment`. However, `pay_for_offer` only allows to set `max_total_routing_fee_msat`, but not other routing-related fields such as `max_total_cltv_expiry_delta`, `max_path_count`, `max_channel_saturation_power_of_half`. I'm...

Previously, we used the `bdk_macros` dependency for some simple proc macros in `lightning-transaction-sync`. However, post-1.0 BDK doesn't further maintain this crate and will at some point probably yank it together...

`rustfmt`: Run on `util/*` (2/2)

5

This is PR 2/2, based on #3324. The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below). FWIW, I...

Add `unregister_tx`/`unregister_output` to `chain::Filter`

2

Currently, a user only gets informed about the transactions to be monitored via `Filter::register_tx`/`Filter::unregister_tx`. We however do not provide any feedback when it would be fine to stop monitoring any...

`rustfmt`: Run on the `routing` directory (2/3)

2

Based on #3336. This is PR 2/3, just formatting `router.rs`. Followups: #3338.

`rustfmt`: Run on the `routing` directory (3/3)

2

Based on #3337. This is PR 3/3, formatting the rest of `routing`.

In https://github.com/lightningdevkit/rust-lightning/pull/3314 we introduced logging around event processing. Logging in the event processing loop will however turn out to be very spammy, in particular since we recently introduced fallible event...