Elias Rohrer

Introduce and enforce MSRV

6

A dependency of `zip` recently bumped the `rustc` requirement to 1.6, leading to MSRV violations in downstream projects such as LDK (cf. https://github.com/lightningdevkit/rust-lightning/pull/2055) and BDK: ``` error: package `base64ct v1.6.0`...

Add user-facing events for applying updates after syncing

1

**Describe the enhancement** When syncing, `Wallet::apply_update` returns `Result` which doesn't give any information if/how all of the changes have been applied. It would be great to return a list of...

Disallow skipping tx-sync tests in CI

1

Minor follow-up to #3020. Previously, we'd always skip tx-sync tests if the `BITCOIND_EXE`/`ELECTRS_EXE` environment variables would be unset. While this is especially fine for local testing, we still want to...

`offer::Quantity::One` is incompatible with `quantity: Some(1)`

8

This is a bit confusing: The `Quantity` variant is named `One`, but `pay_for_offer` fails to send the invoice request with an `UnexpectedQuantity` error if the `quantity` argument is `Some(1)`. Seems...

`rustfmt`: Run on `lightning-persister`

1

We run `rustfmt` on the `lightning-persister` crate. Seems rather straightforward.

`rustfmt`: Run on `lightning-invoice`

5

We run `rustfmt` on the `lightning-invoice` crate.

#2995 followups

1

Closes #3191. We address two minor follow-ups for #2995.

Upgrade to `rust-bitcoin` 0.32

4

In #3063 we bumped to `rust-bitcoin` 0.31. Synced with BDK and they will make the move to 0.32 in the next release (https://github.com/bitcoindevkit/bdk/issues/1422), which means we're not only free to...

Persist `ChannelMonitor` after first setting `balances_empty_height` in `archive_fully_resolved_channel_monitors`

1

In https://github.com/lightningdevkit/ldk-node/pull/307#discussion_r1635388630 @G8XSU observed that our current implementation of `ChainMonitor::archive_fully_resolved_channel_monitors` isn't necessarily suited for mobile use as we currently don't trigger persist after initially setting `balances_empty_height` in `ChannelMonitor`: https://github.com/lightningdevkit/rust-lightning/blob/cc9fc650b8a17295bc65f0415b0dad2d7220d8fc/lightning/src/chain/channelmonitor.rs#L1906 This...

Document persistence failure behavior for all events

1

We addressed most of #2097 in #2995. However, we still need to document for each event type what the expected persistence failure behavior is, especially if we fail to persist...