Takeshi KOMIYA comments

Results 181 comments of


                                            Takeshi KOMIYA

Maintainer for Rails gems wanted

Hi, I'm also interested in improving and maintaining rbs_rails and the types of rails. Either core maintainers or reviewers are okay with me.

railties: Move the definition of PluginGenerator.app_path to railties.rbs

ah, sorry. It's mistake... I'd like to do only moving `Rails::Generator::PluginGenerator#app_path`...

railties: Move the definition of PluginGenerator.app_path to railties.rbs

Now I busted zombies from #692.

railties: Move the definition of PluginGenerator.app_path to railties.rbs

/merge

activemodel: Add ActiveModel::API

/merge

activerecord: Add type for AR::QueryMethods::WhereChain#associated

Thanks!

activerecord: Add type for AR::QueryMethods::WhereChain#associated

/merge

Fix type signature for `ActiveRecord::Base.validate` (to better support official Ruby documentation)

Thank you for your mention. I sincerely apologize. It completely slipped my mind. I'm not sure why you added test cases to ActiveRecord in spite of modifying ActiveModel. Is it...

Fix type signature for `ActiveRecord::Base.validate` (to better support official Ruby documentation)

LGTM for this, but I could not approve this. On my local, reviewing UI is not displayed to me. @ksss Can you approve this?

Fix type signature for `ActiveRecord::Base.validate` (to better support official Ruby documentation)

@ksss thanks!