Fix type signature for `ActiveRecord::Base.validate` (to better support official Ruby documentation)
According to https://guides.rubyonrails.org/v6.0/active_record_validations.html#combining-validation-conditions
the official documentation says you can have
if: [Proc.new { |c| c.market.retail? }, :desktop?],
so, RBS signatures should reflect that.
@yuzisee Thanks for your contribution!
Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md
Available commands
You can use the following commands by commenting on this PR.
/merge: Merge this PR if CI passes
activerecord
You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.
@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.
Thank you for your mention. I sincerely apologize. It completely slipped my mind.
I'm not sure why you added test cases to ActiveRecord in spite of modifying ActiveModel. Is it better to move them to ActiveModel?
LGTM for this, but I could not approve this. On my local, reviewing UI is not displayed to me.
@ksss Can you approve this?
@yuzisee @tk0miya Thanks!
Thanks for your review, @ksss!
@yuzisee, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.
@ksss thanks!
/merge