gem_rbs_collection icon indicating copy to clipboard operation
gem_rbs_collection copied to clipboard

railties: Move the definition of PluginGenerator.app_path to railties.rbs

Open tk0miya opened this issue 1 year ago • 1 comments

As a preparation of https://github.com/ruby/gem_rbs_collection/pull/693, this moves the definition of Rails::Generator::PluginGenerator#app_path to railties.rbs

tk0miya avatar Oct 24 '24 06:10 tk0miya

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

railties

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

github-actions[bot] avatar Oct 24 '24 06:10 github-actions[bot]

ah, sorry. It's mistake... I'd like to do only moving Rails::Generator::PluginGenerator#app_path...

tk0miya avatar Oct 28 '24 10:10 tk0miya

Now I busted zombies from #692.

tk0miya avatar Oct 28 '24 10:10 tk0miya

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged. Just comment /merge to merge this PR.

github-actions[bot] avatar Oct 30 '24 02:10 github-actions[bot]

/merge

tk0miya avatar Oct 30 '24 02:10 tk0miya