Takeshi KOMIYA

Results 181 comments of Takeshi KOMIYA

Now I moved the new definition to railities.rbs

FYI: API doc mentions the return value of `#delete_all`. > Returns the number of rows affected. > https://api.rubyonrails.org/classes/ActiveRecord/Relation.html#method-i-delete_all

I noticed `ActiveRecord::Associations::CollectionProxy#delete_all` takes an optional argument `dependent`. But `ActiveRecord::Associations::Relation#delete_all` does not take arguments at all. But the current design of rbs_rails expects both to be the same. Therefore it's...

@shimizukawa could you check this please? AFAIK, this behavior is a specification of gettext builder, right?

As I commented above, this might be a specification of gettext builder. I think there are no workaround for it.

Surely, it would be better to make `SubstitutionDefinitionsRemover` as a post transform.

There are comment about duplication on domain. I think we have to check and warn duplications at here. https://github.com/sphinx-doc/sphinx/blob/020c51532bc70289926797e878856997415cd2f8/sphinx/domains/std.py#L549-L571