Ted Su

Results 13 comments of Ted Su

Did some research and found an old PR from @adudenamedruby that had fixed this 3 years ago. Here's the old [issue](https://github.com/mozilla-mobile/firefox-ios/issues/7956) and [PR](https://github.com/mozilla-mobile/firefox-ios/pull/8145). The old issue also points to the...

@adudenamedruby I found the [PR](https://github.com/mozilla-mobile/firefox-ios/pull/16660) and [Issue](https://github.com/mozilla-mobile/firefox-ios/issues/16340) that removed the dynamic URL bar code. There was an issue with the on screen keyboard overlapping the bottom part of the URL...

![Screenshot 2024-05-10 at 11 23 56 AM](https://github.com/mozilla-mobile/firefox-ios/assets/98071325/a9f0e5a9-4a8f-4742-817f-1b00ede437e1) ## Before - iOS Asks User Permission Repeatedly https://github.com/mozilla-mobile/firefox-ios/assets/98071325/9fa502ab-4894-4868-8ab3-02836f8402d9 ## After - iOS No Longer Asking Permission https://github.com/mozilla-mobile/firefox-ios/assets/98071325/521762ec-7be3-414b-91fa-0b437a6f12d5

@mattreaganmozilla We can no longer display the URL on the toast as the app should not read the pasteboard before the user clicks on `UIPasteControl`. The UI for `UIPasteControl` is...

@mattreaganmozilla There were no discussions outside of the ticket. I originally did have a fix that did as the ticket asked for. I had `ClipboardBarDisplayHandler` register a nil from the...

@mattreaganmozilla Oops, first time doing a rebase. I fixed the PR.

Linting Swift files in current working directory Linting 'ActionViewController.swift' (1/222) Linting 'AppShortcutsTests.swift' (2/222) Linting 'Package.swift' (3/222) Linting 'AppColorsView.swift' (4/222) Linting 'AppImagesView.swift' (5/222) Linting 'AppFontsView.swift' (6/222) Linting 'UIFont+AppFonts.swift' (7/222) Linting 'UIImage+AppImages.swift'...

> This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏 Conflict resolved.

> This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏 Conflict resolved.