firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-8863 - Enabled SwiftLint attributes for Focus

Open tisumi99 opened this issue 10 months ago • 6 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Enabled SwiftLint rule attributes for Focus. Corrected new lint violations.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

tisumi99 avatar Apr 25 '24 18:04 tisumi99

Linting Swift files in current working directory Linting 'ActionViewController.swift' (1/222) Linting 'AppShortcutsTests.swift' (2/222) Linting 'Package.swift' (3/222) Linting 'AppColorsView.swift' (4/222) Linting 'AppImagesView.swift' (5/222) Linting 'AppFontsView.swift' (6/222) Linting 'UIFont+AppFonts.swift' (7/222) Linting 'UIImage+AppImages.swift' (8/222) Linting 'UIColor+AppColors.swift' (9/222) Linting 'Bundle+CurrentBundle.swift' (10/222) Linting 'LicenseListView.swift' (11/222) Linting 'LicenseList.swift' (12/222) Linting 'AsyncImageView.swift' (13/222) Linting 'UIButton+Background.swift' (14/222) Linting 'ImageLoader.swift' (15/222) Linting 'UIViewController+Child.swift' (16/222) Linting 'UIScreenExtensions.swift' (17/222) Linting 'UIImageExtensions.swift' (18/222) Linting 'UIViewExtensions.swift' (19/222) Linting 'UIApplication+Orientation.swift' (20/222) Linting 'FaviIconGenerator.swift' (21/222) Linting 'UILabelExtensions.swift' (22/222) Linting 'UITableView+Dequeue.swift' (23/222) Linting 'UIDeviceExtensions.swift' (24/222) Linting 'PortraitHostingController.swift' (25/222) Linting 'ToolTipRoute.swift' (27/222) Linting 'OnboardingEventsHandlerV2.swift' (26/222) Linting 'OnboardingVersion.swift' (28/222) Linting 'OnboardingEventsHandlerV1.swift' (29/222) Linting 'OnboardingEventsHandling.swift' (30/222) Linting 'Action.swift' (31/222) Linting 'Image+AppImages.swift' (32/222) Linting 'Color+AppColors.swift' (33/222) Linting 'Font+AppFonts.swift' (34/222) Linting 'TooltipTableViewCell.swift' (35/222) Linting 'TooltipViewController.swift' (36/222) Linting 'TooltipView.swift' (37/222) Linting 'GetStartedOnboardingView.swift' (39/222) Linting 'ShowMeHowOnboardingView.swift' (40/222) Linting 'OnboardingSearchWidgetView.swift' (38/222) Linting 'DefaultBrowserOnboardingView.swift' (41/222) Linting 'OnboardingView.swift' (42/222) Linting 'CardBannerView.swift' (43/222) Linting 'OnboardingViewModel.swift' (44/222) Linting 'OnboardingPreview.swift' (45/222) Linting 'OnboardingViewController.swift' (46/222) Linting 'ShortcutViewModel.swift' (47/222) Linting 'ShortcutView.swift' (48/222) Linting 'Shortcut.swift' (49/222) Linting 'ShortcutsPersister.swift' (51/222) Linting 'ShortcutsManager.swift' (50/222) Linting 'Deferred.swift' (52/222) Linting 'ReadWriteLock.swift' (53/222) Linting 'LockProtected.swift' (54/222) Linting 'AppInfo.swift' (55/222) Linting 'Settings.swift' (56/222) Linting 'Utils.swift' (57/222) Linting 'AppConfig.swift' (58/222) Linting 'ActionRequestHandler.swift' (59/222) Linting 'get_supported_locales.swift' (60/222) Linting 'SettingsTableViewToggleCell.swift' (61/222) Linting 'SettingsTableViewAccessoryCell.swift' (62/222) Linting 'SettingsTableViewCell.swift' (63/222) Linting 'AutocompleteSettingViewController.swift' (64/222) Linting 'AddCustomDomainViewController.swift' (65/222) Linting 'SafariInstructionsViewController.swift' (66/222) Linting 'AddSearchEngineViewController.swift' (67/222) Linting 'SearchSettingsViewController.swift' (68/222) Linting 'AutocompleteCustomUrlViewController.swift' (69/222) Linting 'AboutViewController.swift' (70/222) Linting 'SettingsContentViewController.swift' (71/222) Linting 'SettingsViewController.swift' (72/222) Linting 'InstructionsView.swift' (73/222) Linting 'ActionFooterView.swift' (74/222) Linting 'BlockerToggle.swift' (75/222) Linting 'BlockerEnabledDetector.swift' (76/222) Linting 'NavigationPath.swift' (77/222) Linting 'TrackingProtectionPageStats.swift' (78/222) Linting 'ToggleItem.swift' (79/222) Linting 'TrackingProtectionState.swift' (80/222) Linting 'TrackingProtectionManager.swift' (81/222) Linting 'SecureConnectionStatus.swift' (82/222) Linting 'TrackingProtectionDelegate.swift' (83/222) Linting 'TrackingProtectionViewController.swift' (84/222) Linting 'SubtitleCell.swift' (85/222) Linting 'TrackingHeaderView.swift' (86/222) Linting 'ImageCell.swift' (87/222) Linting 'SwitchTableViewCell.swift' (88/222) Linting 'SheetModalViewController.swift' (89/222) Linting 'SheetMetrics.swift' (90/222) Linting 'TipManager.swift' (91/222) Linting 'ShareTrackersViewController.swift' (93/222) Linting 'TipsPageViewController.swift' (92/222) Linting 'TipViewController.swift' (94/222) Linting 'WebEngineRefactorFlagManager.swift' (95/222) Linting 'InternalSettingsView.swift' (96/222) Linting 'InternalExperimentDetailView.swift' (97/222) Linting 'InternalExperimentsSettingsView.swift' (98/222) Linting 'InternalOnboardingSettingsView.swift' (99/222) Linting 'InternalTelemetrySettingsView.swift' (100/222) Linting 'InternalSettings.swift' (101/222) Linting 'InternalCrashReportingSettingsView.swift' (102/222) Linting 'HomeViewController.swift' (103/222) Linting 'ShortcutsPresenter.swift' (104/222) Linting 'OverlayView.swift' (105/222) Linting 'SearchSuggestionsPromptView.swift' (106/222) Linting 'CharacterSetExtensions.swift' (107/222) Linting 'StringExtensions.swift' (108/222) Linting 'FileManagerExtensions.swift' (109/222) Linting 'URLExtensions.swift' (110/222) Linting 'ClosedRangeExtensions.swift' (111/222) Linting 'UIPasteBoardExtensions.swift' (112/222) Linting 'SearchEngineManager.swift' (113/222) Linting 'SearchEngine.swift' (114/222) Linting 'OpenSearchParser.swift' (115/222) Linting 'UIConstants.swift' (116/222) Linting 'AutocompleteTextField.swift' (117/222) Linting 'ShortcutView+UIContextMenuInteractionDelegate.swift' (118/222) Linting 'GradientBackgroundView.swift' (119/222) Linting 'URLBar.swift' (120/222) Linting 'URLBarDelegate.swift' (121/222) Linting 'Combine+UIControl.swift' (122/222) Linting 'URLBarViewModel.swift' (123/222) Linting 'SmartLabel.swift' (124/222) Linting 'SplashViewController.swift' (125/222) Linting 'BrowserToolbar.swift' (126/222) Linting 'GradientProgressBar.swift' (127/222) Linting 'UIAlertController+Rename.swift' (128/222) Linting 'ErrorPage.swift' (129/222) Linting 'InsetButton.swift' (130/222) Linting 'Toast.swift' (131/222) Linting 'EditView.swift' (132/222) Linting 'HomeViewToolbar.swift' (133/222) Linting 'Metadata.swift' (134/222) Linting 'WebCacheUtils.swift' (135/222) Linting 'UserDefault.swift' (136/222) Linting 'FindInPageBar.swift' (137/222) Linting 'SearchHistoryUtils.swift' (138/222) Linting 'AuthenticationManager.swift' (139/222) Linting 'LocalContentBlocker.swift' (140/222) Linting 'SearchInContentTelemetry.swift' (141/222) Linting 'TelemetryIntegration.swift' (142/222) Linting 'TitleActivityItemProvider.swift' (143/222) Linting 'SearchSuggestClient.swift' (144/222) Linting 'OpenUtils.swift' (145/222) Linting 'AdsTelemetryHelper.swift' (146/222) Linting 'SupportUtils.swift' (147/222) Linting 'OnboardingTelemetryHelper.swift' (148/222) Linting 'Debouncer.swift' (149/222) Linting 'KeyboardType.swift' (150/222) Linting 'InternalURL.swift' (151/222) Linting 'URIFixup.swift' (152/222) Linting 'KeyboardHelper.swift' (153/222) Linting 'NimbusExtensions.swift' (154/222) Linting 'NimbusWrapper.swift' (155/222) Linting 'ThemeViewController.swift' (156/222) Linting 'SystemThemeDelegate.swift' (157/222) Linting 'ThemeTableViewToggleCell.swift' (158/222) Linting 'ThemeTableViewAccessoryCell.swift' (159/222) Linting 'Theme.swift' (160/222) Linting 'MenuAction.swift' (161/222) Linting 'PhotonActionSheetItem+MenuAction.swift' (162/222) Linting 'UIAction+MenuAction.swift' (163/222) Linting 'PhotonActionSheet.swift' (164/222) Linting 'PhotonActionSheetCell.swift' (165/222) Linting 'MenuItemProvider.swift' (166/222) Linting 'WebMenuAction.swift' (167/222) Linting 'MenuActionable.swift' (168/222) Linting 'BrowserViewController.swift' (169/222) Linting 'RequestHandler.swift' (170/222) Linting 'TrackingProtection.swift' (171/222) Linting 'PaddedSwitch.swift' (172/222) Linting 'DomainCompletion+ErrorMessage.swift' (173/222) Linting 'DomainCompletion.swift' (174/222) Linting 'InsetTextField.swift' (175/222) Linting 'SiriFavoriteViewController.swift' (176/222) Linting 'SiriShortcuts.swift' (177/222) Linting 'AppDelegate.swift' (178/222) Linting 'LegacyWebViewController.swift' (179/222) Linting 'SectionItem.swift' (180/222) Linting 'DataSource.swift' (181/222) Linting 'OnboardingConstants.swift' (182/222) Linting 'OnboardingFactory.swift' (183/222) Linting 'AsianLocaleTest.swift' (184/222) Linting 'WebsiteMemoryTest.swift' (185/222) Linting 'SettingAppearanceTest.swift' (186/222) Linting 'CopyTest.swift' (187/222) Linting 'URLValidationTest.swift' (188/222) Linting 'TrackingProtectionTest.swift' (189/222) Linting 'SearchSuggestionsTest.swift' (190/222) Linting 'BaseTestCase.swift' (191/222) Linting 'PastenGoTest.swift' (192/222) Linting 'CollapsedURLTest.swift' (193/222) Linting 'DragAndDropTest.swift' (194/222) Linting 'RequestDesktopTest.swift' (195/222) Linting 'SearchProviderTest.swift' (196/222) Linting 'OpenInFocusTest.swift' (197/222) Linting 'BasicBrowsing.swift' (198/222) Linting 'WebsiteAccessTest.swift' (199/222) Linting 'XCUIApplication+Buttons.swift' (200/222) Linting 'TestHelpers.swift' (201/222) Linting 'PageShortcutsTest.swift' (202/222) Linting 'OnboardingTest.swift' (203/222) Linting 'FindInPageTest.swift' (204/222) Linting 'UserAgentTest.swift' (205/222) Linting 'URIFixupTests.swift' (206/222) Linting 'BrowserViewControllerTests.swift' (207/222) Linting 'URLExtensionsTests.swift' (208/222) Linting 'SupportUtilsTest.swift' (209/222) Linting 'NavigationPathTests.swift' (210/222) Linting 'RequestHandlerTests.swift' (211/222) Linting 'SearchEngineTests.swift' (212/222) Linting 'DomainCompletionTests.swift' (213/222) Linting 'TrackingAdsTests.swift' (214/222) Linting 'SearchEngineManagerTests.swift' (215/222) Linting 'SnapshotHelper.swift' (216/222) Linting 'MarketingTests.swift' (217/222) Linting 'BaseTestCaseL10n.swift' (218/222) Linting 'SnapshotTests.swift' (219/222) Linting 'IntentHandler.swift' (220/222) Linting 'SearchWidgetView.swift' (221/222) Linting 'Widgets.swift' (222/222) Done linting! Found 0 violations, 0 serious in 222 files.

+------------------------------------------+--------+-------------+------------------------+-------------+----------+----------------+---------------+ | identifier | opt-in | correctable | enabled in your config | kind | analyzer | uses sourcekit | configuration | +------------------------------------------+--------+-------------+------------------------+-------------+----------+----------------+---------------+ | accessibility_label_for_image | yes | no | no | lint | no | yes | severity: ... | | accessibility_trait_for_button | yes | no | no | lint | no | yes | severity: ... | | anonymous_argument_in_multiline_closure | yes | no | no | idiomatic | no | no | severity: ... | | anyobject_protocol | yes | yes | no | lint | no | no | severity: ... | | array_init | yes | no | no | lint | no | no | severity: ... | | attributes | yes | no | yes | style | no | no | severity: ... | | balanced_xctest_lifecycle | yes | no | no | lint | no | no | severity: ... | | blanket_disable_command | no | no | no | lint | no | no | severity: ... | | block_based_kvo | no | no | no | idiomatic | no | no | severity: ... | | capture_variable | yes | no | no | lint | yes | yes | severity: ... | | class_delegate_protocol | no | no | no | lint | no | no | severity: ... | | closing_brace | no | yes | yes | style | no | no | severity: ... | | closure_body_length | yes | no | no | metrics | no | no | warning: 3... | | closure_end_indentation | yes | yes | no | style | no | yes | severity: ... | | closure_parameter_position | no | no | no | style | no | no | severity: ... | | closure_spacing | yes | yes | no | style | no | no | severity: ... | | collection_alignment | yes | no | no | style | no | no | severity: ... | | colon | no | yes | no | style | no | no | severity: ... | | comma | no | yes | no | style | no | no | severity: ... | | comma_inheritance | yes | yes | no | style | no | no | severity: ... | | comment_spacing | no | yes | yes | lint | no | no | severity: ... | | compiler_protocol_init | no | no | yes | lint | no | no | severity: ... | | computed_accessors_order | no | no | yes | style | no | no | severity: ... | | conditional_returns_on_newline | yes | no | no | style | no | no | severity: ... | | contains_over_filter_count | yes | no | no | performance | no | no | severity: ... | | contains_over_filter_is_empty | yes | no | no | performance | no | no | severity: ... | | contains_over_first_not_nil | yes | no | yes | performance | no | no | severity: ... | | contains_over_range_nil_comparison | yes | no | yes | performance | no | no | severity: ... | | control_statement | no | yes | no | style | no | no | severity: ... | | convenience_type | yes | no | no | idiomatic | no | no | severity: ... | | custom_rules | no | no | no | style | no | yes | | | cyclomatic_complexity | no | no | no | metrics | no | no | warning: 1... | | deployment_target | no | no | no | lint | no | no | severity: ... | | direct_return | yes | yes | no | style | no | no | severity: ... | | discarded_notification_center_observer | yes | no | no | lint | no | no | severity: ... | | discouraged_assert | yes | no | no | idiomatic | no | no | severity: ... | | discouraged_direct_init | no | no | no | lint | no | no | severity: ... | | discouraged_none_name | yes | no | no | idiomatic | no | no | severity: ... | | discouraged_object_literal | yes | no | no | idiomatic | no | no | severity: ... | | discouraged_optional_boolean | yes | no | no | idiomatic | no | no | severity: ... | | discouraged_optional_collection | yes | no | no | idiomatic | no | no | severity: ... | | duplicate_conditions | no | no | no | lint | no | no | severity: ... | | duplicate_enum_cases | no | no | yes | lint | no | no | severity: ... | | duplicate_imports | no | yes | yes | idiomatic | no | no | severity: ... | | duplicated_key_in_dictionary_literal | no | no | no | lint | no | no | severity: ... | | dynamic_inline | no | no | no | lint | no | no | severity: ... | | empty_collection_literal | yes | no | yes | performance | no | no | severity: ... | | empty_count | yes | no | no | performance | no | no | severity: ... | | empty_enum_arguments | no | yes | yes | style | no | no | severity: ... | | empty_parameters | no | yes | yes | style | no | no | severity: ... | | empty_parentheses_with_trailing_closure | no | yes | yes | style | no | no | severity: ... | | empty_string | yes | no | yes | performance | no | no | severity: ... | | empty_xctest_method | yes | no | no | lint | no | no | severity: ... | | enum_case_associated_values_count | yes | no | no | metrics | no | no | warning: 5... | | expiring_todo | yes | no | no | lint | no | yes | approachin... | | explicit_acl | yes | no | no | idiomatic | no | yes | severity: ... | | explicit_enum_raw_value | yes | no | no | idiomatic | no | no | severity: ... | | explicit_init | yes | yes | yes | idiomatic | no | no | severity: ... | | explicit_self | yes | yes | no | style | yes | yes | severity: ... | | explicit_top_level_acl | yes | no | no | idiomatic | no | no | severity: ... | | explicit_type_interface | yes | no | no | idiomatic | no | no | severity: ... | | extension_access_modifier | yes | no | no | idiomatic | no | yes | severity: ... | | fallthrough | yes | no | no | idiomatic | no | no | severity: ... | | fatal_error_message | yes | no | no | idiomatic | no | no | severity: ... | | file_header | yes | no | no | style | no | yes | severity: ... | | file_length | no | no | no | metrics | no | yes | warning: 4... | | file_name | yes | no | no | idiomatic | no | no | severity: ... | | file_name_no_space | yes | no | no | idiomatic | no | no | severity: ... | | file_types_order | yes | no | no | style | no | yes | severity: ... | | first_where | yes | no | yes | performance | no | no | severity: ... | | flatmap_over_map_reduce | yes | no | no | performance | no | no | severity: ... | | for_where | no | no | no | idiomatic | no | no | severity: ... | | force_cast | no | no | no | idiomatic | no | no | severity: ... | | force_try | no | no | yes | idiomatic | no | no | severity: ... | | force_unwrapping | yes | no | no | idiomatic | no | no | severity: ... | | function_body_length | no | no | no | metrics | no | no | warning: 5... | | function_default_parameter_at_end | yes | no | no | idiomatic | no | no | severity: ... | | function_parameter_count | no | no | no | metrics | no | no | warning: 5... | | generic_type_name | no | no | no | idiomatic | no | no | min_length... | | ibinspectable_in_extension | yes | no | no | lint | no | no | severity: ... | | identical_operands | yes | no | no | lint | no | no | severity: ... | | identifier_name | no | no | no | style | no | yes | min_length... | | implicit_getter | no | no | yes | style | no | no | severity: ... | | implicit_return | yes | yes | no | style | no | no | severity: ... | | implicitly_unwrapped_optional | yes | no | no | idiomatic | no | no | severity: ... | | inclusive_language | no | no | yes | style | no | no | severity: ... | | indentation_width | yes | no | no | style | no | yes | severity: ... | | inert_defer | yes | no | no | lint | no | no | severity: ... | | invalid_swiftlint_command | no | no | yes | lint | no | no | severity: ... | | is_disjoint | no | no | no | idiomatic | no | no | severity: ... | | joined_default_parameter | yes | yes | no | idiomatic | no | no | severity: ... | | large_tuple | no | no | yes | metrics | no | no | warning: 2... | | last_where | yes | no | no | performance | no | no | severity: ... | | leading_whitespace | no | yes | no | style | no | no | severity: ... | | legacy_cggeometry_functions | no | yes | no | idiomatic | no | no | severity: ... | | legacy_constant | no | yes | no | idiomatic | no | no | severity: ... | | legacy_constructor | no | yes | no | idiomatic | no | no | severity: ... | | legacy_hashing | no | no | no | idiomatic | no | no | severity: ... | | legacy_multiple | yes | no | no | idiomatic | no | no | severity: ... | | legacy_nsgeometry_functions | no | yes | no | idiomatic | no | no | severity: ... | | legacy_objc_type | yes | no | no | idiomatic | no | no | severity: ... | | legacy_random | no | no | no | idiomatic | no | no | severity: ... | | let_var_whitespace | yes | no | no | style | no | yes | severity: ... | | line_length | no | no | no | metrics | no | yes | warning: 1... | | literal_expression_end_indentation | yes | yes | no | style | no | yes | severity: ... | | local_doc_comment | yes | no | no | lint | no | no | severity: ... | | lower_acl_than_parent | yes | yes | no | lint | no | no | severity: ... | | mark | no | yes | no | lint | no | yes | severity: ... | | missing_docs | yes | no | no | lint | no | yes | warning: [... | | modifier_order | yes | yes | yes | style | no | yes | severity: ... | | multiline_arguments | yes | no | yes | style | no | no | severity: ... | | multiline_arguments_brackets | yes | no | no | style | no | no | severity: ... | | multiline_function_chains | yes | no | no | style | no | yes | severity: ... | | multiline_literal_brackets | yes | no | no | style | no | yes | severity: ... | | multiline_parameters | yes | no | no | style | no | no | severity: ... | | multiline_parameters_brackets | yes | no | no | style | no | yes | severity: ... | | multiple_closures_with_trailing_closure | no | no | no | style | no | no | severity: ... | | nesting | no | no | no | metrics | no | yes | type_level... | | nimble_operator | yes | yes | no | idiomatic | no | yes | severity: ... | | no_extension_access_modifier | yes | no | no | idiomatic | no | no | severity: ... | | no_fallthrough_only | no | no | no | idiomatic | no | no | severity: ... | | no_grouping_extension | yes | no | no | idiomatic | no | no | severity: ... | | no_magic_numbers | yes | no | no | idiomatic | no | no | severity: ... | | no_space_in_method_call | no | yes | yes | style | no | no | severity: ... | | non_overridable_class_declaration | yes | yes | no | style | no | no | severity: ... | | notification_center_detachment | no | no | no | lint | no | no | severity: ... | | ns_number_init_as_function_reference | no | no | no | lint | no | no | severity: ... | | nslocalizedstring_key | yes | no | no | lint | no | no | severity: ... | | nslocalizedstring_require_bundle | yes | no | no | lint | no | no | severity: ... | | nsobject_prefer_isequal | no | no | no | lint | no | no | severity: ... | | number_separator | yes | yes | no | style | no | no | severity: ... | | object_literal | yes | no | no | idiomatic | no | no | severity: ... | | opening_brace | no | yes | yes | style | no | yes | severity: ... | | operator_usage_whitespace | yes | yes | no | style | no | no | severity: ... | | operator_whitespace | no | no | no | style | no | no | severity: ... | | optional_enum_case_matching | yes | yes | no | style | no | no | severity: ... | | orphaned_doc_comment | no | no | no | lint | no | no | severity: ... | | overridden_super_call | yes | no | yes | lint | no | no | severity: ... | | override_in_extension | yes | no | no | lint | no | no | severity: ... | | pattern_matching_keywords | yes | no | no | idiomatic | no | no | severity: ... | | period_spacing | yes | yes | no | style | no | no | severity: ... | | prefer_nimble | yes | no | no | idiomatic | no | no | severity: ... | | prefer_self_in_static_references | yes | yes | no | style | no | no | severity: ... | | prefer_self_type_over_type_of_self | yes | yes | no | style | no | no | severity: ... | | prefer_zero_over_explicit_init | yes | yes | no | idiomatic | no | no | severity: ... | | prefixed_toplevel_constant | yes | no | no | style | no | no | severity: ... | | private_action | yes | no | no | lint | no | no | severity: ... | | private_outlet | yes | no | no | lint | no | no | severity: ... | | private_over_fileprivate | no | yes | no | idiomatic | no | no | severity: ... | | private_subject | yes | no | no | lint | no | no | severity: ... | | private_swiftui_state | yes | no | no | lint | no | no | severity: ... | | private_unit_test | no | yes | no | lint | no | no | severity: ... | | prohibited_interface_builder | yes | no | no | lint | no | no | severity: ... | | prohibited_super_call | yes | no | no | lint | no | no | severity: ... | | protocol_property_accessors_order | no | yes | no | style | no | no | severity: ... | | quick_discouraged_call | yes | no | no | lint | no | yes | severity: ... | | quick_discouraged_focused_test | yes | no | no | lint | no | no | severity: ... | | quick_discouraged_pending_test | yes | no | no | lint | no | no | severity: ... | | raw_value_for_camel_cased_codable_enum | yes | no | no | lint | no | no | severity: ... | | reduce_boolean | no | no | no | performance | no | no | severity: ... | | reduce_into | yes | no | no | performance | no | no | severity: ... | | redundant_discardable_let | no | yes | no | style | no | no | severity: ... | | redundant_nil_coalescing | yes | yes | no | idiomatic | no | no | severity: ... | | redundant_objc_attribute | no | yes | no | idiomatic | no | no | severity: ... | | redundant_optional_initialization | no | yes | no | idiomatic | no | no | severity: ... | | redundant_self_in_closure | yes | yes | no | style | no | no | severity: ... | | redundant_set_access_control | no | no | no | idiomatic | no | no | severity: ... | | redundant_string_enum_value | no | no | no | idiomatic | no | no | severity: ... | | redundant_type_annotation | yes | yes | no | idiomatic | no | yes | severity: ... | | redundant_void_return | no | yes | no | idiomatic | no | no | severity: ... | | required_deinit | yes | no | no | lint | no | no | severity: ... | | required_enum_case | yes | no | no | lint | no | no | {Protocol ... | | return_arrow_whitespace | no | yes | no | style | no | no | severity: ... | | return_value_from_void_function | yes | no | no | idiomatic | no | no | severity: ... | | self_binding | yes | yes | no | style | no | no | severity: ... | | self_in_property_initialization | no | no | no | lint | no | no | severity: ... | | shorthand_operator | no | no | no | style | no | no | severity: ... | | shorthand_optional_binding | yes | yes | no | idiomatic | no | no | severity: ... | | single_test_class | yes | no | no | style | no | no | severity: ... | | sorted_enum_cases | yes | no | no | style | no | no | severity: ... | | sorted_first_last | yes | no | no | performance | no | no | severity: ... | | sorted_imports | yes | yes | no | style | no | yes | severity: ... | | statement_position | no | yes | no | style | no | yes | severity: ... | | static_operator | yes | no | no | idiomatic | no | no | severity: ... | | strict_fileprivate | yes | no | no | idiomatic | no | no | severity: ... | | strong_iboutlet | yes | yes | no | lint | no | no | severity: ... | | superfluous_disable_command | no | no | no | lint | no | no | severity: ... | | superfluous_else | yes | no | no | style | no | no | severity: ... | | switch_case_alignment | no | no | no | style | no | no | severity: ... | | switch_case_on_newline | yes | no | no | style | no | no | severity: ... | | syntactic_sugar | no | yes | no | idiomatic | no | no | severity: ... | | test_case_accessibility | yes | yes | no | lint | no | no | severity: ... | | todo | no | no | no | lint | no | no | severity: ... | | toggle_bool | yes | yes | no | idiomatic | no | no | severity: ... | | trailing_closure | yes | no | no | style | no | yes | severity: ... | | trailing_comma | no | yes | no | style | no | no | severity: ... | | trailing_newline | no | yes | no | style | no | no | severity: ... | | trailing_semicolon | no | yes | no | idiomatic | no | no | severity: ... | | trailing_whitespace | no | yes | yes | style | no | yes | severity: ... | | type_body_length | no | no | no | metrics | no | no | warning: 2... | | type_contents_order | yes | no | no | style | no | yes | severity: ... | | type_name | no | no | no | idiomatic | no | no | min_length... | | typesafe_array_init | yes | no | no | lint | yes | yes | severity: ... | | unavailable_condition | no | no | no | idiomatic | no | no | severity: ... | | unavailable_function | yes | no | no | idiomatic | no | no | severity: ... | | unhandled_throwing_task | yes | no | no | lint | no | no | severity: ... | | unneeded_break_in_switch | no | yes | no | idiomatic | no | no | severity: ... | | unneeded_override | no | yes | no | lint | no | no | severity: ... | | unneeded_parentheses_in_closure_argument | yes | yes | no | style | no | no | severity: ... | | unneeded_synthesized_initializer | no | yes | no | idiomatic | no | no | severity: ... | | unowned_variable_capture | yes | no | no | lint | no | no | severity: ... | | untyped_error_in_catch | yes | yes | no | idiomatic | no | no | severity: ... | | unused_capture_list | yes | no | no | lint | no | no | severity: ... | | unused_closure_parameter | no | yes | no | lint | no | no | severity: ... | | unused_control_flow_label | no | yes | no | lint | no | no | severity: ... | | unused_declaration | yes | no | no | lint | yes | yes | severity: ... | | unused_enumerated | no | no | no | idiomatic | no | no | severity: ... | | unused_import | yes | yes | yes | lint | yes | yes | severity: ... | | unused_optional_binding | no | no | no | style | no | no | severity: ... | | unused_setter_value | no | no | no | lint | no | no | severity: ... | | valid_ibinspectable | no | no | no | lint | no | no | severity: ... | | vertical_parameter_alignment | no | no | no | style | no | no | severity: ... | | vertical_parameter_alignment_on_call | yes | no | yes | style | no | no | severity: ... | | vertical_whitespace | no | yes | yes | style | no | yes | severity: ... | | vertical_whitespace_between_cases | yes | yes | no | style | no | yes | severity: ... | | vertical_whitespace_closing_braces | yes | yes | yes | style | no | yes | severity: ... | | vertical_whitespace_opening_braces | yes | yes | yes | style | no | yes | severity: ... | | void_function_in_ternary | no | no | no | idiomatic | no | no | severity: ... | | void_return | no | yes | no | style | no | yes | severity: ... | | weak_delegate | yes | no | no | lint | no | no | severity: ... | | xct_specific_matcher | yes | no | no | idiomatic | no | no | severity: ... | | xctfail_message | no | no | no | idiomatic | no | no | severity: ... | | yoda_condition | yes | no | yes | lint | no | no | severity: ... | +------------------------------------------+--------+-------------+------------------------+-------------+----------+----------------+---------------+

tisumi99 avatar Apr 25 '24 18:04 tisumi99

This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏

mergify[bot] avatar Apr 26 '24 10:04 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏

Conflict resolved.

tisumi99 avatar Apr 26 '24 16:04 tisumi99

This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏

mergify[bot] avatar Apr 26 '24 20:04 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @tisumi99? 🙏

Conflict resolved.

tisumi99 avatar Apr 26 '24 21:04 tisumi99

@jjSDET Hi, can you please approve this PR? Thanks.

tisumi99 avatar May 10 '24 18:05 tisumi99