The navigation bar has become very thick

[arnavbhate]

Steps to reproduce

Open Firefox

Expected behavior

Normal size navigation bar

Actual behavior

Thick navigation bar with extra spacing

Device & build information

• Device: iPad Air (5th generation), iPadOS 17.2
• Build version: 121.2 (37524)
• First seen version: New to this version

Notes

Reinstalled firefox from app store and issue still persists. Attachments:

┆Issue is synchronized with this Jira Task

[afurlan-firefox]

From the screenshot, I can see the regular padding on the navigation bar. Have you noticed any change compared with previous versions? If so, can you attach the screenshots. Thanks!

[arnavbhate]

From the screenshot, I can see the regular padding on the navigation bar. Have you noticed any change compared with previous versions? If so, can you attach the screenshots. Thanks!

I don't have any prior screen shots, but compare with the iPad screenshots on the app store. That is what it looked like. In the new version, there is just too much padding above and below the address bar.

[rajparad]

For this issue, I think it's not only in iPad. I also checked for Mobile, after comparing it App store it seems like there is more padding. I am attaching screenshots below. For the issue LocationHeight=40 in URLBarViewUX in URLBarView class can be cause. I am not sure LocationHeight has been changes recently, or we use specific values for this var. After changing it to higher number it works fine, but please suggest @lmarceau

Appstore Image:

Current Simulator Image:

[tisumi99]

Did some research and found an old PR from @adudenamedruby that had fixed this 3 years ago. Here's the old issue and PR. The old issue also points to the URL bar being too tall (too much bottom padding). The explanation was that the added height was needed to to accomodate the larger text sizes that a user can set in the iOS accessibility settings. The fix was to make the URL bar height dynamic.

The odd thing is the code to make the URL bar dynamic is no longer in the code base. When I copy the dynamic code from the old PR into my sandbox branch, it solves this issue. So not sure why the code was removed and not sure if I should put it back in.

Couple of screenshots from my sandbox branch with the restored code.

[adudenamedruby]

o wow, I did fix this. Go me! lol

@tisumi99 thanks for looking into this. Before fixing, would you mind looking to see what PR it was removed in, so we can try to understand why it was removed in the first place. It may have been accidental, or intentional.

[tisumi99]

@adudenamedruby I found the PR and Issue that removed the dynamic URL bar code. There was an issue with the on screen keyboard overlapping the bottom part of the URL bar when the bar is set at the bottom. Removing the dynamic code fixed the overlapping issue since having a fixed taller URL bar avoided the overlap. But now we are back at having a too tall URL bar when the bar is set at the top. So I'll restore the dynamic code but only activate it when the URL bar is at the top.