Tim te Beek
Tim te Beek
> This project uses Java 7, so I expect that this will not be compatible. Ah hadn't thought of that; [you're right](https://junit.org/junit5/docs/current/user-guide/#overview-java-versions). > JUnit 5 requires Java 8 (or higher)...
Good suggestion; applied just now, although it's not immediately clear to me whether this has any chance of getting merged (soon-ish), and/or what would be required to get it in...
Noticed the `Build with Coverage reports` [does not yet have the color flag](https://github.com/timtebeek/AxonFramework/blob/apache_maven_wrapper_3.8.6/.github/workflows/main.yml#L46); would you like to see that added in?
Added just now; feel free to do a final check! :)
``` [ERROR] Failures: [ERROR] TrackingEventProcessorTest.testTokenIsExtendedAtStartAndStoredAtEndOfEventBatch_WithStoringTokensAfterProcessingSetting:457 Unexpected number of invocations of token extension in unit of work ==> expected: but was: ``` First time seeing that test fail ; looks to...
Not sure if this 'll work in your case, but at work we had to add a `RUN yum update -y` to our Dockerfile. Which is weird since that's also...
> Not sure if this 'll work in your case, but at work we had to add a `RUN yum update -y` to our Dockerfile. As of today this workaround...
Just adding a link here to the issues for easier cross reference: #1584: MALFORMED_RESPONSE_CHUNK with the Accept-Encoding: [gzip] does not send the required HTTP 200 first.
Some of these are perhaps a bit nitpicky, but overall they help the code readability. I had disabled a few that caused too many changes for little added value. Also...
@jamietanna Would you mind reviewing this one? :)