Tim te Beek

Results 1243 comments of Tim te Beek

Not sure if we'd be able to remove the appended space at present; I'm hoping https://github.com/spring-projects/spring-shell/discussions/474 turns up something we can use immediately. Until then I guess the improvements above...

Think we can [pick this up again](https://github.com/spring-projects/spring-shell/commit/4bab975ecf04e0466d3ef2bfd63c868c25f37440).

Let's wait for your branch to merge first then; I'll be on holiday myself starting next week until the end of the year, so anyone welcome to pick this up...

I have some experience with [detecting unused (non private) methods and classes through ArchUnit](https://blog.jdriven.com/2021/01/detect-delete-unreferenced-code-with-archunit/). In practice there's a lot of caveats that are framework and project specific before you're able...

These were introduced as part of this change by @tomakehurst to remove the dependency on Conscrypt for ALPN and HTTP/2: https://github.com/wiremock/wiremock/commit/5303f8db65dd9b8165dab2d88d2b7441c6e3959f Thought I'd post the link here, since tracking the...

Yeah happy to help! Finally noticed that if I run `mvn test -Prbac` locally it actually matches some tests. Was a bit surprising that plain `mvn test` didn't match anything;...

Just FYI; the `Run` link in [CONTRIBUTING.md](https://github.com/kafka-ops/julie/blob/master/CONTRIBUTING.md#contribution-steps) is not working anymore.

The tests weren't run because of mismatched versions of surefire/failsafe; Fixed in https://github.com/kafka-ops/julie/pull/534/commits/cd3f0fcb6474ba6efc6806ace4b59ed72a0c0c70. @purbon Would you mind running the tests? :pray:

I'm [looking at the test](https://github.com/timtebeek/julie/blob/junit5/src/test/java/com/purbon/kafka/topology/integration/TopicManagerIT.java#L97) now; it does indeed also fail locally. The test executes a plan to create two topics, which are indeed created. What's unclear to me is...

@purbon the test failures was resolved in https://github.com/kafka-ops/julie/pull/534/commits/cf59d8d76475b0ffa968380ecb9b72666bdcb4d8; hope you agree!