apache
Switch to JUnit Jupiter
Via mvn -U org.openrewrite.maven:rewrite-maven-plugin:4.32.0:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:1.26.1 -DactiveRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices
- [x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
This project uses Java 7, so I expect that this will not be compatible.
Ah hadn't thought of that; you're right.
JUnit 5 requires Java 8 (or higher) at runtime. However, you can still test code that has been compiled with previous versions of the JDK.
Unless we want to bring in toolchains to test on a different Java version, I guess this is blocked for now.
Good suggestion; applied just now, although it's not immediately clear to me whether this has any chance of getting merged (soon-ish), and/or what would be required to get it in a mergeable state.
Yes I'd love to see this through, but will be traveling until early January. Welcome to push the required changes already, or recreate using the Maven plugin for OpenRewrite. Otherwise I'll pick this up as soon as I get back.
On Thu, Dec 22, 2022, 11:54 Benjamin Marwell @.***> wrote:
@timtebeek https://github.com/timtebeek it is now Java 8 -- would you like to change it back?
— Reply to this email directly, view it on GitHub https://github.com/apache/maven-wrapper/pull/61#issuecomment-1362934686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH22BUX53QWIZRQXNNY7DLWORTUDANCNFSM57QJ6HTQ . You are receiving this because you were mentioned.Message ID: @.***>
@bmarwell suggestions applied, and further fixes to reduce visibility and convert the new HashAlgorithmVerifierTest. Ready for review! :)
@bmarwell recreated this one as well, as discussed; again mostly automated, with spotless apply committed separately from the OpenRewrite automation. Glad to see spotless added here. :) Ready for review & merge.