Tim te Beek

Results 1243 comments of Tim te Beek

Thanks both! Wondering a bit indeed how we can make this safe; we don't immediately have a way to know if a method might be overridden, unless we use a...

Interesting case; at first glance I was surprised the first one compiles despite the `break` statement. Thank you for reporting this issue! Replicated with the following test, which should fit...

Hmm; that's a bit unfortunate indeed, but hopefully rare; In this case it's the shortest one that's missing its options; glad at least that we correctly reject that in the...

I could see a case though to always fully qualify; especially with a Spring Boot 3.x best practices containing 2556 recipes, it might make sense to always fully qualify the...

hi @junseoparkk ; appreciate the offer to help! Welcome to get started; we'll assign the issue to you as soon as there is a draft PR. :)

Thanks! The validation error is printed in the Maven plugin: https://github.com/openrewrite/rewrite-maven-plugin/blob/63175862aca93b57ad85364505f09dbb58b8cea5/src/main/java/org/openrewrite/maven/AbstractRewriteBaseRunMojo.java#L142-L144 Based on the missing property passed into this method: https://github.com/openrewrite/rewrite/blob/8ce5308a9557dd6ca91253a5c8fb7e6c34a0ef5a/rewrite-core/src/main/java/org/openrewrite/Validated.java#L110-L114 Likely coming from this method where we (now) only...

Hmm; I indeed see the type information for that Guava `contains` being linked to `com.google.common.collect.ImmutableCollection contains(java.lang.Object)`, which fits in with [their `abstract` override](https://github.com/google/guava/blob/41c7d2ddbf6a6f28b85d6a3ef53ac223a22ba224/guava/src/com/google/common/collect/ImmutableCollection.java#L252-L253), which according to our type system is...

Thanks for the help! Copying [the failure from the logs](https://github.com/openrewrite/rewrite/actions/runs/14868677582/job/41751749992?pr=5391#step:6:7767) here to make it easier to follow up: ``` JavadocTest > methodFoundInSuperclassBecauseSuperclassFieldsTakesPresenceOverInterfaceFields() FAILED org.opentest4j.AssertionFailedError: expected: but was: at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at...

Great to see! Linking this discussion here as I imagine we'd need that `visit(memberRef.getContaining(), compareTo.getContaining());` reintroduced here before a merge: - https://github.com/openrewrite/rewrite/pull/5394#discussion_r2077413969

Thanks for the suggestion and offer to help @amishra-u ! It's indeed a common sight to have to wrangle explicit imports even when using JavaTemplate to make changes. I suppose...