Tim te Beek

Results 1243 comments of Tim te Beek

Thanks for logging an issue! Indeed hard to say what to do when there's no clear best way to go about it. We could prevent the `IndexOutOfBoundsException` with a quick...

Let's opt for the IDE warnings first then; should be doable. Logging isn't really an option given how many different ways there are to run recipes.

Thanks for the added details! I think the Groovy parsing issues are separate; when we fail to parse a file then we don't run any recipes on those. They are...

Did you manually truncate the `Error while visiting src/main/java/.java` above? That would be the best indication of which file fails. Are there any logging-like methods in that particular file?

Hmm; a mental parse doesn't immediately spot any problematic logging statements, but perhaps there's some interplay between first making them parameterized and then converting. Attaching a debugger would likely help....

hi! Thanks for the report; that's odd, since we had a similar report and related fix earlier: - https://github.com/openrewrite/rewrite/issues/631 https://github.com/openrewrite/rewrite-static-analysis/blob/1cdcfbd0ce088ec54dbfe0a72a796b2a767aa2df/src/test/java/org/openrewrite/staticanalysis/UnnecessaryThrowsTest.java#L88-L110

Also can't seem to replicate this with a minimal unit test: ```java @Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/728") @Test void necessaryThrowsFromCloseable2() { rewriteRun( //language=java java( """ import java.io.IOException; import java.io.InputStream; class Test { void readResource()...

Much appreciated, thanks! I'm out for the next two weeks, but could be interesting to take on after. Or anyone else that wants to step up in the mean time.

Thanks for the report! For `HideUtilityClassConstructor` there is already the option to provide a style with annotation classes that should not see their default constructor hidden: https://github.com/openrewrite/rewrite/blob/03c458404073082275a752063887c188d213afbe/rewrite-java/src/main/java/org/openrewrite/java/style/HideUtilityClassConstructorStyle.java#L27-L33 https://github.com/openrewrite/rewrite-static-analysis/blob/8e44876b985c0afd190faffe8516da68952b7954/src/main/java/org/openrewrite/staticanalysis/HideUtilityClassConstructor.java#L59-L63 For `FinalClass`...

Might also want to take into account cases like the following, where you wouldn't want to shift the code left ``` // SomeIndented.butCommentedOut(code); ```