Tim te Beek

Results 1243 comments of Tim te Beek

Hmm; thanks for diving in! It looks like the annotation is still present at this point in the parsing: https://github.com/openrewrite/rewrite/blob/a98d83d698dda9971c93a0767b7f85d5866f306d/rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17Parser.java#L193-L194 ![image](https://github.com/user-attachments/assets/8c225205-4da3-4d9d-a064-ddb0190e2363) But it's gone when we exit that `org.openrewrite.java.isolated.ReloadableJava17Parser#parseInputsToCompilerAst` 🤔

Thanks for the detailed look! Problems sure have a way of looking deceptively simple don't they? 🙃 Let me tag @knutwannheden here as he might have some ideas too, even...

We've since improved how records are parsed in - https://github.com/openrewrite/rewrite/pull/5916 I _think_ we can close this issue, as that's been available as of https://github.com/openrewrite/rewrite/releases/tag/v8.62.0 ; thanks for the help!

In terms of implementation we'll want a `JavaVisitor` (not a `JavaIsoVisitor`) that overrides `visitAnnotation`, and for any matching `@__` annotation returns the arguments passed into the annotation instead of the...

hi @nddipiazza-ebay ; Appreciate your concern when running on a large project; We've had some internal discussions around this subject in the past as well, most recently in - https://github.com/openrewrite/rewrite-maven-plugin/issues/544#issuecomment-1665569864...

Also: perhaps you'd be interested to pass in `-Drewrite.metricsUri=LOG` or even a proper URI to get some metrics out of your recipe runs; that might help you to monitor what...

hi! Those recipes first have to be written and contributed to the project; I've logged a small break down of tasks for Spring Boot: - https://github.com/openrewrite/rewrite-spring/issues/642 Welcome to help out...

This PR from @wapkch helpfully includes some of the steps above already: - https://github.com/openrewrite/rewrite-spring/pull/693 - https://github.com/openrewrite/rewrite-spring/pull/689

Only seeing this issue now; thanks for the report @tubbynl ! A fix would be appreciated indeed, perhaps starting with a unit test for the corresponding recipe, as seen here:...

Hi @ppkarwasz ; thanks for the offer to help! Agree that we can split these concerns and make each of those available as a separate recipe, with perhaps a combined...