Tim Holy

Results 1853 comments of Tim Holy

Yeah, I'm not exactly sure how that would work. You'd need a name per package, right? I guess we could automate the name selection based on `@__MODULE__`? But then users...

Maybe I'm misunderstanding your proposal, but is that different from https://github.com/timholy/SnoopCompile.jl/blob/01552bc8ac3ccffb3699b983fbba960fcaa22e91/SnoopPrecompile/src/SnoopPrecompile.jl#L9-L13 and https://github.com/timholy/SnoopCompile.jl/blob/01552bc8ac3ccffb3699b983fbba960fcaa22e91/SnoopPrecompile/src/SnoopPrecompile.jl#L57 ? The issue is that PkgA depends on SnoopPrecompile, but SnoopPrecompile depends on the compile-time preference `skip_precompile`....

For two reasons: 1. Preference-loading depends on the path you launch Julia from. See below. 2. For non-devved packages, if you stored the flag in the package's own LocalPreferences.jl you'd...

> It depends on your project/load path, not the path you launch Julia from. True. I guess we can solve this if we have SnoopPrecompile handle all the mangling: ```julia...

The plan is to do that once it can be done with a reasonable architecture. Currently, the stack (omitting OrderedCollections) is CodeTracking -> JuliaInterpreter -> LoweredCodeUtils -> Revise. This stack...

There's a possible reproducer at https://github.com/aviatesk/JET.jl/pull/648 (unless I'm just being an idiot and not seeing a typo or something).

I had even copy/pasted the name but clearly I didn't get them all. It seems like it would be useful to check for small errors. But I note the stacktrace...

Fixed in [9e3fd08](https://github.com/timholy/Revise.jl/pull/894/commits/9e3fd08b4849ba2b76617a55399424f7a2ebd47d) but currently that's only on the unmerged #894

I recognize this is one of the CodeTracking bugs identified in #401, where it finds the wrong method: ```julia julia> mi = badmis[end-7] MethodInstance for (Vector)(::Vector{S}) where S julia> mi.def...

I'm guessing it's because the user is making that conversion because they care about the order in the resulting object, but if you're converting from an unordered container the resulting...