Tim Holy
Tim Holy
Though I should point out that perhaps the right way to solve this problem also ropes in #1047, so perhaps I should wait on your response to that issue first.
I'll try to put together a PR soon; I'll leave #1047 out of it and just document the current state.
A specific proposal: ```julia export PWrapper struct PWrapper{MMUL, MDIV} Mmul::MMUL Mdiv::MDIV end lsqr(A, b; M=PWrapper(M, nothing)) # equivalent to default ldiv=false lsqr(A, b; M=PWrapper(nothing, factoredM)) # equivalent to specifying `M`...
I suspect there's a way to add something like this that might be non-breaking; the code could check for a `PWrapper`. In the longer term, one would want to get...
> The issue with your suggestions is that we don't know anymore what is the preconditioner to use (M or M⁻¹ ?). Good point. We could change it to ```julia...
Revise doesn't handle structs yet. See #894
For my own coding, I use vscode for editing (and all the fancy Julia-features y'all have added :heart:) but I execute all my code in the terminal REPL. Some of...
> We need a few more modifications in src/interfaces.jl and it should be good I think. I am sure you're right, but I'll need some hints about where. Note that...
Locally this seems non-breaking.
I'm unclear on whether the macos failures are "my fault" (I don't think so). And, can I see the updated breakage report (i.e., like https://github.com/JuliaSmoothOptimizers/Krylov.jl/pull/1038#issuecomment-3566621249) myself? I clicked on the...