Dependencies cleanup 🧹

[timdeschryver]

Which @ngrx/* package(s) are relevant/related to the feature request?

store

Information

Take a look at dependencies and either update or remove the reference. Examples:

• update ESLint
• remove Protractor

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

• [x] Yes
• [ ] No

[rainerhahnekamp]

Good idea!

[jdegand]

@timdeschryver Have you thought about removing Jasmine? At present, it is mostly used for spies in the tests. There is a jest-marbles library that should be able to replace the jasmine-marbles library. These would be the potential dependencies that could be removed. This should help test speed as well and I know you increased CI time to handle slow tests.

"jasmine": "^3.4.0",
"jasmine-core": "4.2.0",
"jasmine-marbles": "0.9.2",
"jasmine-spec-reporter": "7.0.0",
"jest-jasmine2": "29.7.0"
"karma": "6.4.0",
"karma-chrome-launcher": "3.1.0",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "3.0.3",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.0.0",
"@types/jasmine": "4.0.3",
"@types/jasminewd2": "^2.0.2",
"protractor": "7.0.0"

[timdeschryver]

For now I think it's fine to keep it as is. If we migrate, I think it's better to skip jest, and use Vitest.

[rainerhahnekamp]

If we migrate, I think it's better to skip jest, and use Vitest.

Fully agree! 💯

[markostanimirovic]

Migration to Vitest can be done incrementally, project by project. We can create issues for each project.

[jdegand]

One dependency that is a problem is eslint-etc. It hasn't been updated in 2 years so this causes peer dependency issues as the range hasn't been updated. There is a pull that would allow it to work with ESLint 9 but I doubt it will get merged. I don't think it is even being used anywhere so it likely can be safely removed.