Thomas Lin Pedersen
Thomas Lin Pedersen
Yes exactly. Having a clear expected output of a method makes it so much easier to build up intuition for what it is supposed to do. You may also think...
Great progress on this! Yes, I think `Guides` (I think it is a better name 🙂) should be the one orchestrating all the calls so `guides_train()` etc should become methods...
Sounds good - ping me whenever needing input
That is obvious a bug and should be fixed. Haven't seen that before🙂
It is great to see all the progress you are making... I'm in the midst of the next ggplot2 release so if it is ok with you I'll wait a...
yeah, I think we may push this to the release after this in order to make the transition a bit smoother?
It would be quite easy to make this a theme setting (I have just fiddled with that code in another matter). What say the @clauswilke, @Hadley, do you have any...
This change intersects with #3683 so I'll wait for that to get merged
ggplot2 handles the basic integer vector like R in general does: as a numeric... It is also not clear to me why you would expect an integer to be mapped...
@Hadley can we agree that the scale type of integers should be continuous? And that any haven specific behaviour should be taken care of separately