Thomas Lin Pedersen comments

Results 675 comments of


                                            Thomas Lin Pedersen

Change minor_breaks interface

@Hadley where are we on this?

Change minor_breaks interface

@Hadley is it viable to get this into the next release?

WIP: Pass actual data to annotation_raster() and annotation_custom() instead of dummy data

Can you add a test for making sure that annotations doesn't affect the scales of the plot?

WIP: Pass actual data to annotation_raster() and annotation_custom() instead of dummy data

I think the intent of the PR is good. annotations should respond to scale transformations, but they should not affect the scales in any way (at least that's my feeling,...

WIP: Pass actual data to annotation_raster() and annotation_custom() instead of dummy data

I agree that we should keep the behaviour in line with the documentation, but do you think we should let it respond to scale transformations? (I do)

WIP: Pass actual data to annotation_raster() and annotation_custom() instead of dummy data

@yutannihilation are you awaiting #3175 for finishing this off? if so, I'll not add it to the 3.2.0 milestone

WIP: Pass actual data to annotation_raster() and annotation_custom() instead of dummy data

No worries... will push this to after the next release

Feature request: support for tibble aesthetics

As the vctrs integration is happening now I'm reading through these older issues. While vctrs would solve some of the issues described herein this is obviously deeper than that and...

`ggsave()` doesn't render custom fonts when saving (+workaround)

There has been no direct change in ggplot2 that changes anything related to extrafonts... However, ggplot2 now defaults to using the ragg device if installed and ragg doesn't care about...

Convert guides to ggproto

I'll take a look next week as conference gets behind me. Thanks for reminding me